'Re: Review Request: Fetch contacts only when contactManager is ready +'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request: Fetch contacts only when contactManager is ready +
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2011-07-29 14:28:10
Message-ID: 20110729142810.18470.23190 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102106/#review5216
-----------------------------------------------------------

Ship it!

Arbitrary line breaks are arbitrary (at the end of the diff).

But seriously, this looks fine.

- George

On July 27, 2011, 9:06 p.m., David Edmundson wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102106/
> -----------------------------------------------------------
> =

> (Updated July 27, 2011, 9:06 p.m.)
> =

> =

> Review request for Telepathy.
> =

> =

> Summary
> -------
> =

> Fetch contacts only when contactManager is ready.
> =

> =

> Replace monitoring of connectionStatusChanged with connectionChanged as t=
hese are not always directly in sync.
> =

> This prevents a potential crash using Account::connection() when it doesn=
't exist.
> =

> =

> Diffs
> -----
> =

>   account.h 265fb86f6f5cde9d5f314136873dc5f95eff0c7a =

>   account.cpp 79d5ec6ac42afd1c935c8625c1f9e6a1b53ef8d1 =

> =

> Diff: http://git.reviewboard.kde.org/r/102106/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> David
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102106/">http://git.reviewboard.kde.org/r/102106/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Arbitrary line breaks \
are arbitrary (at the end of the diff).

But seriously, this looks fine.</pre>
 <br />

<p>- George</p>

<br />
<p>On July 27th, 2011, 9:06 p.m., David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated July 27, 2011, 9:06 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fetch contacts only when contactManager is ready.

Replace monitoring of connectionStatusChanged with connectionChanged as these are not \
always directly in sync.

This prevents a potential crash using Account::connection() when it doesn&#39;t \
exist.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>account.h <span style="color: \
grey">(265fb86f6f5cde9d5f314136873dc5f95eff0c7a)</span></li>

 <li>account.cpp <span style="color: \
grey">(79d5ec6ac42afd1c935c8625c1f9e6a1b53ef8d1)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102106/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 