[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request: This is the patch to enable nextTab and
From: "George Goldberg" <grundleborg () googlemail ! com>
Date: 2011-07-20 15:16:48
Message-ID: 20110720151648.29442.54806 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On May 13, 2011, 4:24 p.m., David Edmundson wrote:
> >
> =
> David Edmundson wrote:
> I should probably have checked this.
> =
> Do you have a KDE SVN account, or were you waiting for one of us to m=
erge it?
>
David, if this still isn't merged and is still relevant, can you commit it?=
Seems a shame to be still rotting in reviewboard.
- George
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101355/#review3299
-----------------------------------------------------------
On May 13, 2011, 4:23 p.m., Tarun Mall wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101355/
> -----------------------------------------------------------
> =
> (Updated May 13, 2011, 4:23 p.m.)
> =
> =
> Review request for Telepathy.
> =
> =
> Summary
> -------
> =
> The patch here will enable:
> Ctrl+Tab -> for next tab
> Ctrl+shift+Tab -> for previous tab
> =
> =
> Diffs
> -----
> =
> app/chat-window.h f9c07da =
> app/chat-window.cpp 149608d =
> =
> Diff: http://git.reviewboard.kde.org/r/101355/diff
> =
> =
> Testing
> -------
> =
> Tested with 1-2 and more number of tabs open.
> =
> =
> Thanks,
> =
> Tarun
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101355/">http://git.reviewboard.kde.org/r/101355/</a>
</td>
</tr>
</table>
<br />
<p>On June 24th, 2011, 10:37 p.m., <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I should probably have \
checked this.
Do you have a KDE SVN account, or were you waiting for one of us to merge it?
</pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">David, if this still \
isn't merged and is still relevant, can you commit it? Seems a shame to be still \
rotting in reviewboard.</pre> <br />
<p>- George</p>
<br />
<p>On May 13th, 2011, 4:23 p.m., Tarun Mall wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Tarun Mall.</div>
<p style="color: grey;"><i>Updated May 13, 2011, 4:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The patch here will enable: Ctrl+Tab -> for next tab
Ctrl+shift+Tab -> for previous tab</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with 1-2 and more number of tabs open.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/chat-window.h <span style="color: grey">(f9c07da)</span></li>
<li>app/chat-window.cpp <span style="color: grey">(149608d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101355/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic