[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request: Remove the deprecated code from telepathy-kde to
From: "George Goldberg" <grundleborg () googlemail ! com>
Date: 2011-07-20 14:35:36
Message-ID: 20110720143536.27008.53591 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 20, 2011, 2:30 p.m., David Edmundson wrote:
> > If you're sure they're not useful to anyone. Ship it! It certainly has =
been causing some confusion.
> > =
> > ModelMenu looks like a useful class on it's own - almost worthy of bein=
g in KDELibs, I'm going to save that.
I think modelmenu was copied from somewhere else in the first place (dolphi=
n iirc). Daniele would know for sure.
- George
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102021/#review4894
-----------------------------------------------------------
On July 20, 2011, 2:25 p.m., George Goldberg wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102021/
> -----------------------------------------------------------
> =
> (Updated July 20, 2011, 2:25 p.m.)
> =
> =
> Review request for Telepathy.
> =
> =
> Summary
> -------
> =
> There seems to be a lot of confusion about what code is meant to be used =
in telepathy-kde and what is deprecated stuff just hanging around in case i=
t is useful. So, this patch removes everything deprecated. We can always re=
instate it from the history at a later date if for some reason we want to r=
esurrect one of these classes, but for now it makes it a hell of a lot more=
obvious which classes to use for stuff.
> =
> =
> Diffs
> -----
> =
> src/CMakeLists.txt f6a24df3274839ac8a42e94a381998a57ff4180c =
> src/KTelepathy/AbstractTreeItem b1dee65b37b4b2c4c71a92ff2360750cdc1860f=
d =
> src/KTelepathy/AccountItem 52c328397b26046ee5c281444188ac4a852abdcd =
> src/KTelepathy/AccountsModel 823d5599396f0d505ebf2895596351fd45e7e4eb =
> src/KTelepathy/ContactItem f31000ed74d9d78deed476441039f3145fcf0115 =
> src/KTelepathy/ContactsListModel 243371c955b0256f3ad80d74f20f9ad6e32818=
c4 =
> src/KTelepathy/ContactsModelMenu aa09334c7a1a78f0d75d518d8281172bfbb00e=
a4 =
> src/KTelepathy/GroupedContactsProxyModel 2b7a7cfee951f5455decfa05485fee=
7c7a47661e =
> src/KTelepathy/MetaContactItem f4cdebd395baf6b95692e13a7db3b6e5697b2dad =
> src/KTelepathy/ModelMenu 419c8d847ee19b2359693941309513fa7dd5f0e9 =
> src/ui/abstract-tree-item.h dc73e5736ab1ec0bfc1895c6d0ce70943df94bc7 =
> src/ui/abstract-tree-item.cpp 30a9b8b67e5cf1b024aa0dd80f59a0d1ff38bd2d =
> src/ui/account-item.h bfab4d51cad503472e944e0426eb7f1b9a54a7c2 =
> src/ui/account-item.cpp 04f6431779bf50d1c6f722490a6eaa9a4625c8e1 =
> src/ui/accounts-model.h a2c3f9df67c56d91b2a61c0eec2ed072dde8bff1 =
> src/ui/accounts-model.cpp 2c095c6b06e69d53c0e1d1b817a9e6faa6040606 =
> src/ui/contact-item.h 37ae163b773adfb48063d04a1a518f7cc196eaeb =
> src/ui/contact-item.cpp 9906245a1c515ad266e33ff425d81deea5358607 =
> src/ui/contacts-list-model.h 4311d0e0b79198adde16d7a967705c04f533f728 =
> src/ui/contacts-list-model.cpp c066d7f21fcfeda0193c3d15afc785cc788f1953 =
> src/ui/contacts-modelmenu.h fcff12be32cf3d652484ab7700250ff5476a1208 =
> src/ui/contacts-modelmenu.cpp 4bb2b3e356185b0e3106aee7c09bb647898cbc15 =
> src/ui/grouped-contacts-proxy-model.h 19530934b98c16d6036b51430e47b2aeb=
7afd654 =
> src/ui/grouped-contacts-proxy-model.cpp 482847b81323ec6053b2b4a97395782=
8ff330e96 =
> src/ui/meta-contact-item.h 2feb9a63edc3a606260ba4a79809a1b8d6de0b74 =
> src/ui/meta-contact-item.cpp 1a5bdd38427fb2ac326dcbd019d1fb89d6e014d6 =
> src/ui/modelmenu.h a8b2dfc38f3ba665bc7fc4aea89a10157fb9f7ba =
> src/ui/modelmenu.cpp 1b69e1e9099ecc3c5c71342ce09421d413319d90 =
> =
> Diff: http://git.reviewboard.kde.org/r/102021/diff
> =
> =
> Testing
> -------
> =
> Everything still compiles.
> =
> =
> Thanks,
> =
> George
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102021/">http://git.reviewboard.kde.org/r/102021/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 20th, 2011, 2:30 p.m., <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If you're sure they're not useful to anyone. Ship it! It \
certainly has been causing some confusion.
ModelMenu looks like a useful class on it's own - almost worthy of being in \
KDELibs, I'm going to save that.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think modelmenu was \
copied from somewhere else in the first place (dolphin iirc). Daniele would know for \
sure.</pre> <br />
<p>- George</p>
<br />
<p>On July 20th, 2011, 2:25 p.m., George Goldberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated July 20, 2011, 2:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There seems to be a lot of confusion about what code is meant to be used \
in telepathy-kde and what is deprecated stuff just hanging around in case it is \
useful. So, this patch removes everything deprecated. We can always reinstate it from \
the history at a later date if for some reason we want to resurrect one of these \
classes, but for now it makes it a hell of a lot more obvious which classes to use \
for stuff.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Everything still compiles.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: \
grey">(f6a24df3274839ac8a42e94a381998a57ff4180c)</span></li>
<li>src/KTelepathy/AbstractTreeItem <span style="color: \
grey">(b1dee65b37b4b2c4c71a92ff2360750cdc1860fd)</span></li>
<li>src/KTelepathy/AccountItem <span style="color: \
grey">(52c328397b26046ee5c281444188ac4a852abdcd)</span></li>
<li>src/KTelepathy/AccountsModel <span style="color: \
grey">(823d5599396f0d505ebf2895596351fd45e7e4eb)</span></li>
<li>src/KTelepathy/ContactItem <span style="color: \
grey">(f31000ed74d9d78deed476441039f3145fcf0115)</span></li>
<li>src/KTelepathy/ContactsListModel <span style="color: \
grey">(243371c955b0256f3ad80d74f20f9ad6e32818c4)</span></li>
<li>src/KTelepathy/ContactsModelMenu <span style="color: \
grey">(aa09334c7a1a78f0d75d518d8281172bfbb00ea4)</span></li>
<li>src/KTelepathy/GroupedContactsProxyModel <span style="color: \
grey">(2b7a7cfee951f5455decfa05485fee7c7a47661e)</span></li>
<li>src/KTelepathy/MetaContactItem <span style="color: \
grey">(f4cdebd395baf6b95692e13a7db3b6e5697b2dad)</span></li>
<li>src/KTelepathy/ModelMenu <span style="color: \
grey">(419c8d847ee19b2359693941309513fa7dd5f0e9)</span></li>
<li>src/ui/abstract-tree-item.h <span style="color: \
grey">(dc73e5736ab1ec0bfc1895c6d0ce70943df94bc7)</span></li>
<li>src/ui/abstract-tree-item.cpp <span style="color: \
grey">(30a9b8b67e5cf1b024aa0dd80f59a0d1ff38bd2d)</span></li>
<li>src/ui/account-item.h <span style="color: \
grey">(bfab4d51cad503472e944e0426eb7f1b9a54a7c2)</span></li>
<li>src/ui/account-item.cpp <span style="color: \
grey">(04f6431779bf50d1c6f722490a6eaa9a4625c8e1)</span></li>
<li>src/ui/accounts-model.h <span style="color: \
grey">(a2c3f9df67c56d91b2a61c0eec2ed072dde8bff1)</span></li>
<li>src/ui/accounts-model.cpp <span style="color: \
grey">(2c095c6b06e69d53c0e1d1b817a9e6faa6040606)</span></li>
<li>src/ui/contact-item.h <span style="color: \
grey">(37ae163b773adfb48063d04a1a518f7cc196eaeb)</span></li>
<li>src/ui/contact-item.cpp <span style="color: \
grey">(9906245a1c515ad266e33ff425d81deea5358607)</span></li>
<li>src/ui/contacts-list-model.h <span style="color: \
grey">(4311d0e0b79198adde16d7a967705c04f533f728)</span></li>
<li>src/ui/contacts-list-model.cpp <span style="color: \
grey">(c066d7f21fcfeda0193c3d15afc785cc788f1953)</span></li>
<li>src/ui/contacts-modelmenu.h <span style="color: \
grey">(fcff12be32cf3d652484ab7700250ff5476a1208)</span></li>
<li>src/ui/contacts-modelmenu.cpp <span style="color: \
grey">(4bb2b3e356185b0e3106aee7c09bb647898cbc15)</span></li>
<li>src/ui/grouped-contacts-proxy-model.h <span style="color: \
grey">(19530934b98c16d6036b51430e47b2aeb7afd654)</span></li>
<li>src/ui/grouped-contacts-proxy-model.cpp <span style="color: \
grey">(482847b81323ec6053b2b4a973957828ff330e96)</span></li>
<li>src/ui/meta-contact-item.h <span style="color: \
grey">(2feb9a63edc3a606260ba4a79809a1b8d6de0b74)</span></li>
<li>src/ui/meta-contact-item.cpp <span style="color: \
grey">(1a5bdd38427fb2ac326dcbd019d1fb89d6e014d6)</span></li>
<li>src/ui/modelmenu.h <span style="color: \
grey">(a8b2dfc38f3ba665bc7fc4aea89a10157fb9f7ba)</span></li>
<li>src/ui/modelmenu.cpp <span style="color: \
grey">(1b69e1e9099ecc3c5c71342ce09421d413319d90)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102021/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic