'Re: Review Request: Use Tp::ConnectionPresenceType instead of uint in'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request: Use Tp::ConnectionPresenceType instead of uint in
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2011-07-20 14:04:07
Message-ID: 20110720140407.25180.87688 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101636/
-----------------------------------------------------------

(Updated July 20, 2011, 2:04 p.m.)

Review request for Telepathy.

Changes
-------

Changed presence type to use Tp::ConnectionPresenceType instead of uint as =
suggested by David.

Summary (updated)
-------

Use Tp::ConnectionPresenceType instead of uint in Person and Contact classe=
s for the presenceType property.

Major work on Contact, Person and PersonSetModel to make all the half imple=
mented bits work properly and as intended.

This means the three classes should now be fully working with all the basic=
 read-only properties, including presence, caps, avatar, groups, displaynam=
e, presence message.

Add presenceType as a piece of info that can be got from the model.

Name the Role enum and make it a QMetaType.

Add support for a ItemTypeRole to the model, which indicates what type the =
Item is, e.g. Person, Contact or Group etc. The idea is that subclasses or =
proxy models will extend this.

Diffs (updated)
-----

  src/core/contact.h 026a7361a35556a261a1ad10910bf846b024bd64 =

  src/core/contact.cpp c91058a261fe4f79dd505d97f901401c09ba53b4 =

  src/core/person.h eb017da98d8a01a8555ef3568f095bf2cfe74109 =

  src/core/person.cpp 4269789b0d45838024901907d728b058ae17e8de =

  src/ui/person-set-model.h 95416fff218ad568149ad453f692a9fcdfa635b2 =

  src/ui/person-set-model.cpp 7a5849af208d7596171ebb8c95adcf488135d73d =

Diff: http://git.reviewboard.kde.org/r/101636/diff

Testing
-------

Unit tests still pass.

Thanks,

George

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101636/">http://git.reviewboard.kde.org/r/101636/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>

<p style="color: grey;"><i>Updated July 20, 2011, 2:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Changed presence type to use Tp::ConnectionPresenceType instead of uint \
as suggested by David.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use Tp::ConnectionPresenceType instead of uint in Person and Contact \
classes for the presenceType property.

Major work on Contact, Person and PersonSetModel to make all the half implemented \
bits work properly and as intended.

This means the three classes should now be fully working with all the basic read-only \
properties, including presence, caps, avatar, groups, displayname, presence message.

Add presenceType as a piece of info that can be got from the model.

Name the Role enum and make it a QMetaType.

Add support for a ItemTypeRole to the model, which indicates what type the Item is, \
e.g. Person, Contact or Group etc. The idea is that subclasses or proxy models will \
extend this.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit tests still pass.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/contact.h <span style="color: \
grey">(026a7361a35556a261a1ad10910bf846b024bd64)</span></li>

 <li>src/core/contact.cpp <span style="color: \
grey">(c91058a261fe4f79dd505d97f901401c09ba53b4)</span></li>

 <li>src/core/person.h <span style="color: \
grey">(eb017da98d8a01a8555ef3568f095bf2cfe74109)</span></li>

 <li>src/core/person.cpp <span style="color: \
grey">(4269789b0d45838024901907d728b058ae17e8de)</span></li>

 <li>src/ui/person-set-model.h <span style="color: \
grey">(95416fff218ad568149ad453f692a9fcdfa635b2)</span></li>

 <li>src/ui/person-set-model.cpp <span style="color: \
grey">(7a5849af208d7596171ebb8c95adcf488135d73d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101636/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 