[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request: Use type instead of status to identify the current
From: "Paolo Capriotti" <p.capriotti () gmail ! com>
Date: 2011-07-18 18:09:59
Message-ID: 20110718180959.21295.4480 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On July 17, 2011, 9:26 p.m., David Edmundson wrote:
> > I can see why you did it, however I'm not sure it's overall right.
> > =
> > Telepathy presence is very confusing, here's a bad attempt at an explan=
ation:
> > =
> > - there are lots of status's defined by "status", this is a string ide=
ntifier. It will be values such as "away" "dnd", "online". =
> > =
> > - because we're dealing with strings telepathy provides a fallback sol=
ution as a smaller fixed set of statuses as a simple enum. This is to be us=
ed if you don't understand the status.
> > =
> > All presence stuff /should/ (but probably don't) be switching on the st=
ring (status), then falling back to using the enum value (type)
> =
> George Goldberg wrote:
> David is spot on with that explanation :)
Yes, I had the wrong idea about what status and type were. After reading th=
e telepathy spec, it makes sense now. =
See http://git.reviewboard.kde.org/r/101992/ for a better patch to solve th=
is problem.
- Paolo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101984/#review4790
-----------------------------------------------------------
On July 17, 2011, 7:43 p.m., Paolo Capriotti wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101984/
> -----------------------------------------------------------
> =
> (Updated July 17, 2011, 7:43 p.m.)
> =
> =
> Review request for Telepathy.
> =
> =
> Summary
> -------
> =
> The presence status does not uniquely identify the current presence, so u=
se type instead.
> =
> =
> Diffs
> -----
> =
> account-button.cpp 2ccda54 =
> =
> Diff: http://git.reviewboard.kde.org/r/101984/diff
> =
> =
> Testing
> -------
> =
> Change presence in contact list, observe that the presence button's toolt=
ip matches the action text for all actions.
> =
> =
> Thanks,
> =
> Paolo
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101984/">http://git.reviewboard.kde.org/r/101984/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On July 17th, 2011, 9:26 p.m., <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I can see why you did it, however I'm not sure it's overall \
right.
Telepathy presence is very confusing, here's a bad attempt at an explanation:
- there are lots of status's defined by "status", this is a string \
identifier. It will be values such as "away" "dnd", \
"online".
- because we're dealing with strings telepathy provides a fallback solution as a \
smaller fixed set of statuses as a simple enum. This is to be used if you don't \
understand the status.
All presence stuff /should/ (but probably don't) be switching on the string \
(status), then falling back to using the enum value (type)</pre> </blockquote>
<p>On July 18th, 2011, 10:33 a.m., <b>George Goldberg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">David is spot on with \
that explanation :)</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, I had the wrong \
idea about what status and type were. After reading the telepathy spec, it makes \
sense now. See http://git.reviewboard.kde.org/r/101992/ for a better patch to solve \
this problem.</pre> <br />
<p>- Paolo</p>
<br />
<p>On July 17th, 2011, 7:43 p.m., Paolo Capriotti wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By Paolo Capriotti.</div>
<p style="color: grey;"><i>Updated July 17, 2011, 7:43 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The presence status does not uniquely identify the current presence, so \
use type instead.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Change presence in contact list, observe that the presence button's \
tooltip matches the action text for all actions.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>account-button.cpp <span style="color: grey">(2ccda54)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101984/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic