'Re: Review Request: Refactor presence handling in AccountButton.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request: Refactor presence handling in AccountButton.
From:       "Paolo Capriotti" <p.capriotti () gmail ! com>
Date:       2011-07-18 0:17:49
Message-ID: 20110718001749.24829.14680 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101992/
-----------------------------------------------------------

(Updated July 18, 2011, 12:17 a.m.)

Review request for Telepathy.

Summary
-------

* Factored out a function to get the correct action corresponding to the
  current presence.
* Use status first for matching, then type if status fails.
* Use 'away' icon for the BRB action.
* Remove unused code.

Diffs
-----

  account-button.h fb98a0d0de34565fb0c92ccd76b737be970ba134 =

  account-button.cpp 7763858d2705e9afb61a196f392eafebc63b09c7 =

Diff: http://git.reviewboard.kde.org/r/101992/diff

Testing (updated)
-------

tested with gabble

Thanks,

Paolo

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101992/">http://git.reviewboard.kde.org/r/101992/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By Paolo Capriotti.</div>

<p style="color: grey;"><i>Updated July 18, 2011, 12:17 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Factored out a function to get the correct action corresponding to the \
                current presence.
* Use status first for matching, then type if status fails.
* Use &#39;away&#39; icon for the BRB action.
* Remove unused code.
</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">tested with gabble</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>account-button.h <span style="color: \
grey">(fb98a0d0de34565fb0c92ccd76b737be970ba134)</span></li>

 <li>account-button.cpp <span style="color: \
grey">(7763858d2705e9afb61a196f392eafebc63b09c7)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101992/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 