'Re: Review Request: Contact Avatar support for Nepomuk Service'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Re: Review Request: Contact Avatar support for Nepomuk Service
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2011-06-17 15:59:19
Message-ID: 20110617155919.11782.54498 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On June 15, 2011, 11:45 p.m., Daniele Elmo Domenichelli wrote:
> > nepomuk-storage.cpp, lines 765-766
> > <http://git.reviewboard.kde.org/r/101633/diff/1/?file=24528#file24528line765>
> > 
> > is this Q_ASSERT necessary?

Yes. If it gets triggered that's a bug, and the best way to make developers notice is \
a crash in debug mode :p

> On June 15, 2011, 11:45 p.m., Daniele Elmo Domenichelli wrote:
> > telepathy.trig, lines 27-33
> > <http://git.reviewboard.kde.org/r/101633/diff/1/?file=24529#file24529line27>
> > 
> > I agree with this change, but maybe it could be the opposite:
> > 
> > telepathy:avatarForIMAccount
> > a rdf:Property ;
> > rdfs:domain nie:DataObject ;
> > rdfs:range nco:IMAccount ;
> > rdfs:subPropertyOf nie:dataSource ;
> > 
> > 
> > But I just realized that to be able to do that, nco:IMAccount (or even \
> > nco:ContactMedium) should be rdfs:subClassOf nie:DataSource, this change could \
> > make sense as well, since nie:Datasource is "A superclass for all entities from \
> > which DataObjects can be extracted" [1] and the avatar is actually a DataObject \
> > that is extracted from the IMAccount 
> > 
> > [1]http://oscaf.sourceforge.net/nie.html#nie:DataSource

Eeek! Let's leave it the way I've done it for now, and then I'll file a ticket \
upstream, and we can discuss the permanent solution there (since I'm sure all the \
oscaf people will want to weigh in on this too).

> On June 15, 2011, 11:45 p.m., Daniele Elmo Domenichelli wrote:
> > telepathy.trig, line 33
> > <http://git.reviewboard.kde.org/r/101633/diff/1/?file=24529#file24529line33>
> > 
> > Another issue is that avatar can be changed, but just dropping this property \
> > means that it will be impossible to search for all the pictures that have been \
> > avatar for a certain account. To fix this, we could have a generic avatar \
> > property and a currentAvatar subProperty, but perhaps this is useless, what do \
> > you think?

I don't think Nepomuk generally stores the history of any other property in this way, \
so I don't think it's appropriate to do that for an Avatar. However, I don't really \
know how Nepomuk takes care of that. Or does it even take care of history of \
properties?

- George

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101633/#review3916
-----------------------------------------------------------

On June 15, 2011, 6:16 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101633/
> -----------------------------------------------------------
> 
> (Updated June 15, 2011, 6:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch reinstates support for Contact Avatars in the Telepathy Nepomuk Service.
> 
> Avatar support for local accounts looks trickier so will come in a subsequent \
> patch. 
> I'd particularly like comments on the changes to the Telepathy ontology. The \
> rationale behind adding the telepathy:avatar property to nco:IMAccount is that \
> although we can use nco:photo, this can contain multiple photos of the contact and \
> we need to be able to identify the one that is the avatar for this IM account. The \
> reason for it not being upstream is that it seems like telepathy-level \
> implementation detail to me (although I will of course discuss this with upstream \
> in due course to see whether they think it might belong there). The result is you \
> are meant to identify one particular nco:photo of the nco:personContact to be the \
> telepathy:avatar. 
> 
> This addresses bug 270864.
> http://bugs.kde.org/show_bug.cgi?id=270864
> 
> 
> Diffs
> -----
> 
> abstract-storage.h 7d1be9b96711500ddd2ab5b6d9aa8791e51bcea1 
> account.h b57ebf881e1bd661bd8db069cc3f5147ce10b515 
> account.cpp e0cfdf0931c75126339e18fb2458a93d510b6e28 
> contact.h ccc482aa36c3d8e38cfa89608043f198ef8be674 
> contact.cpp bc5a29100e380bbcb7ae48930813d19842b0a836 
> controller.cpp f320326534c8b76ea73097c906d82c2b90a35f22 
> nepomuk-storage.h 216239371b0656dff61c4a189a709703094b7418 
> nepomuk-storage.cpp 7d154494b759e2b9bca95d086f164f1a71ab1095 
> telepathy.trig d5a07d202185cc0d9aaa0fbd681cfd0202fa88c1 
> tests/controller-test.h cd85a675d731b43c0960e0b5ba3fb02d8aacade7 
> tests/storage-test.h ab5f05f2e5faf6b0710c2dfd9f8d3f21ae06d330 
> tests/storage-test.cpp 2ff9428f57f2515c60c9fe7fb24c46d9f6907b7d 
> 
> Diff: http://git.reviewboard.kde.org/r/101633/diff
> 
> 
> Testing
> -------
> 
> Unit tests (updated appropriately) all pass.
> 
> 
> Thanks,
> 
> George
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101633/">http://git.reviewboard.kde.org/r/101633/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 15th, 2011, 11:45 p.m., <b>Daniele Elmo \
Domenichelli</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101633/diff/1/?file=24528#file24528line765" \
style="color: black; font-weight: bold; text-decoration: \
underline;">nepomuk-storage.cpp</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>  <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">void NepomukStorage::setContactAvatar(const QString &amp;path,</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">765</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="n">Q_ASSERT</span><span class="p">(</span><span \
class="n">m_contacts</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="n">identifier</span><span class="p">));</span></pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">766</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="k">if</span> <span class="p">(</span><span class="o">!</span><span \
class="n">m_contacts</span><span class="p">.</span><span \
class="n">contains</span><span class="p">(</span><span \
class="n">identifier</span><span class="p">))</span> <span \
class="p">{</span></pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is this Q_ASSERT \
necessary?</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. If it \
gets triggered that&#39;s a bug, and the best way to make developers notice is a \
crash in debug mode :p</pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 15th, 2011, 11:45 p.m., <b>Daniele Elmo \
Domenichelli</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101633/diff/1/?file=24529#file24529line27" \
style="color: black; font-weight: bold; text-decoration: \
underline;">telepathy.trig</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">26</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">            \
telepathy:avatar</pre></td>  </tr>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">27</font></th>  <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th>  <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">     a \
rdf:Property ;</pre></td>  </tr>

 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">          \
rdfs:comment &quot;The photo which is the IM Account&#39;s avatar. This is a special \
case of the nco:photo property of the parent nco:personContact.&quot; ;</pre></td>  \
</tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">          \
rdfs:domain nco:IMAccount ;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">          \
rdfs:label &quot;avatar&quot; ;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">          \
rdfs:range nie:DataObject ;</pre></td>  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">          \
nrl:maxCardinality &quot;1&quot; .</pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree with this \
change, but maybe it could be the opposite:

telepathy:avatarForIMAccount
   a rdf:Property ;
   rdfs:domain nie:DataObject ;
   rdfs:range nco:IMAccount ;
   rdfs:subPropertyOf nie:dataSource ;

But I just realized that to be able to do that, nco:IMAccount (or even \
nco:ContactMedium) should be rdfs:subClassOf nie:DataSource, this change could make \
sense as well, since nie:Datasource is &quot;A superclass for all entities from which \
DataObjects can be extracted&quot; [1] and the avatar is actually a DataObject that \
is extracted from the IMAccount

[1]http://oscaf.sourceforge.net/nie.html#nie:DataSource</pre>
 </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Eeek! \
Let&#39;s leave it the way I&#39;ve done it for now, and then I&#39;ll file a ticket \
upstream, and we can discuss the permanent solution there (since I&#39;m sure all the \
oscaf people will want to weigh in on this too).</pre> <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On June 15th, 2011, 11:45 p.m., <b>Daniele Elmo \
Domenichelli</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://git.reviewboard.kde.org/r/101633/diff/1/?file=24529#file24529line33" \
style="color: black; font-weight: bold; text-decoration: \
underline;">telepathy.trig</a>  <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">          \
nrl:maxCardinality &quot;1&quot; .</pre></td>  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Another issue is that \
avatar can be changed, but just dropping this property means that it will be \
impossible to search for all the pictures that have been avatar for a certain \
account. To fix this, we could have a generic avatar property and a currentAvatar \
subProperty, but perhaps this is useless, what do you think?</pre>  </blockquote>

</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don&#39;t \
think Nepomuk generally stores the history of any other property in this way, so I \
don&#39;t think it&#39;s appropriate to do that for an Avatar. However, I don&#39;t \
really know how Nepomuk takes care of that. Or does it even take care of history of \
properties?</pre> <br />

<p>- George</p>

<br />
<p>On June 15th, 2011, 6:16 p.m., George Goldberg wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>

<p style="color: grey;"><i>Updated June 15, 2011, 6:16 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch reinstates support for Contact Avatars in the Telepathy \
Nepomuk Service.

Avatar support for local accounts looks trickier so will come in a subsequent patch.

I&#39;d particularly like comments on the changes to the Telepathy ontology. The \
rationale behind adding the telepathy:avatar property to nco:IMAccount is that \
although we can use nco:photo, this can contain multiple photos of the contact and we \
need to be able to identify the one that is the avatar for this IM account. The \
reason for it not being upstream is that it seems like telepathy-level implementation \
detail to me (although I will of course discuss this with upstream in due course to \
see whether they think it might belong there). The result is you are meant to \
identify one particular nco:photo of the nco:personContact to be the \
telepathy:avatar.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Unit tests (updated appropriately) all pass.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=270864">270864</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>abstract-storage.h <span style="color: \
grey">(7d1be9b96711500ddd2ab5b6d9aa8791e51bcea1)</span></li>

 <li>account.h <span style="color: \
grey">(b57ebf881e1bd661bd8db069cc3f5147ce10b515)</span></li>

 <li>account.cpp <span style="color: \
grey">(e0cfdf0931c75126339e18fb2458a93d510b6e28)</span></li>

 <li>contact.h <span style="color: \
grey">(ccc482aa36c3d8e38cfa89608043f198ef8be674)</span></li>

 <li>contact.cpp <span style="color: \
grey">(bc5a29100e380bbcb7ae48930813d19842b0a836)</span></li>

 <li>controller.cpp <span style="color: \
grey">(f320326534c8b76ea73097c906d82c2b90a35f22)</span></li>

 <li>nepomuk-storage.h <span style="color: \
grey">(216239371b0656dff61c4a189a709703094b7418)</span></li>

 <li>nepomuk-storage.cpp <span style="color: \
grey">(7d154494b759e2b9bca95d086f164f1a71ab1095)</span></li>

 <li>telepathy.trig <span style="color: \
grey">(d5a07d202185cc0d9aaa0fbd681cfd0202fa88c1)</span></li>

 <li>tests/controller-test.h <span style="color: \
grey">(cd85a675d731b43c0960e0b5ba3fb02d8aacade7)</span></li>

 <li>tests/storage-test.h <span style="color: \
grey">(ab5f05f2e5faf6b0710c2dfd9f8d3f21ae06d330)</span></li>

 <li>tests/storage-test.cpp <span style="color: \
grey">(2ff9428f57f2515c60c9fe7fb24c46d9f6907b7d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101633/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 