'Review Request: Fix query to populate a Person with Contacts'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-telepathy
Subject:    Review Request: Fix query to populate a Person with Contacts
From:       "George Goldberg" <grundleborg () googlemail ! com>
Date:       2011-06-08 16:03:52
Message-ID: 20110608160352.28082.88961 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101546/
-----------------------------------------------------------

Review request for Telepathy.

Summary
-------

Fix the query that populates a Person with their Contacts to actually work =
with current ontologies.

Diffs
-----

  src/core/person.cpp 813b41fa1541214fd9617127dac7f6ca1226676c =

Diff: http://git.reviewboard.kde.org/r/101546/diff

Testing
-------

Manually verified this now works. Unfortunately, there is no unit test cove=
rage for this functionality yet, but it's going to be a big operation to se=
t up, so it'll have to come in a separate patch.

Thanks,

George

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/101546/">http://git.reviewboard.kde.org/r/101546/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix the query that populates a Person with their Contacts to actually \
work with current ontologies.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manually verified this now works. Unfortunately, there is no unit test \
coverage for this functionality yet, but it&#39;s going to be a big operation to set \
up, so it&#39;ll have to come in a separate patch.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/person.cpp <span style="color: \
grey">(813b41fa1541214fd9617127dac7f6ca1226676c)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/101546/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy

[prev in list] [next in list] [prev in thread] [next in thread] 