[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-telepathy
Subject: Re: Review Request: fix usage of deprecated tpqt4 signals
From: "George Goldberg" <grundleborg () googlemail ! com>
Date: 2011-06-08 14:47:54
Message-ID: 20110608144754.24386.45983 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 8, 2011, 1:14 p.m., Daniele Elmo Domenichelli wrote:
> > contact.cpp, lines 66-67
> > <http://git.reviewboard.kde.org/r/101541/diff/2/?file=24068#file24068line66>
> >
> > Probably also the Contact::onPublishStateChanged and the \
> > Contact::publishStateChanged should be modified to reflect this change and emit \
> > the message as well
Yes, that's true. However, there's no way of storing this in the ontology for now, so \
I'll leave that for another patch.
- George
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101541/#review3765
-----------------------------------------------------------
On June 8, 2011, 12:23 p.m., George Goldberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101541/
> -----------------------------------------------------------
>
> (Updated June 8, 2011, 12:23 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Fix usage of deprecated tpqt4 signals.
>
>
> Diffs
> -----
>
> contact.cpp 4a1c5c61a06446f8fde80df71a396022b658e545
>
> Diff: http://git.reviewboard.kde.org/r/101541/diff
>
>
> Testing
> -------
>
> unit tests still pass
>
>
> Thanks,
>
> George
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101541/">http://git.reviewboard.kde.org/r/101541/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 8th, 2011, 1:14 p.m., <b>Daniele Elmo \
Domenichelli</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101541/diff/2/?file=24068#file24068line66" \
style="color: black; font-weight: bold; text-decoration: underline;">contact.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Contact::init()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">66</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">SIGNAL</span><span class="p">(</span><span \
class="n">publishStateChanged</span><span class="p">(</span><span \
class="n">Tp</span><span class="o">::</span><span class="n">Contact</span><span \
class="o">::</span><span class="n">PresenceState</span><span class="p">,</span><span \
class="n"><span class="hl">Tp</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span \
class="hl">Channel</span></span><span class="o"><span \
class="hl">::</span></span><span class="n"><span \
class="hl">GroupMemberChangeDetails</span></span><span \
class="p">)),</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">66</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">SIGNAL</span><span \
class="p">(</span><span class="n">publishStateChanged</span><span \
class="p">(</span><span class="n">Tp</span><span class="o">::</span><span \
class="n">Contact</span><span class="o">::</span><span \
class="n">PresenceState</span><span class="p">,</span><span class="hl"> </span><span \
class="n"><span class="hl">QString</span></span><span class="p">)),</span></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">67</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">SLOT</span><span class="p">(</span><span \
class="n">onPublishStateChanged</span><span class="p">(</span><span \
class="n">Tp</span><span class="o">::</span><span class="n">Contact</span><span \
class="o">::</span><span class="n">PresenceState</span><span \
class="p">)));</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">67</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">SLOT</span><span \
class="p">(</span><span class="n">onPublishStateChanged</span><span \
class="p">(</span><span class="n">Tp</span><span class="o">::</span><span \
class="n">Contact</span><span class="o">::</span><span \
class="n">PresenceState</span><span class="p">)));</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Probably also the \
Contact::onPublishStateChanged and the Contact::publishStateChanged should be \
modified to reflect this change and emit the message as well</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, \
that's true. However, there's no way of storing this in the ontology for now, \
so I'll leave that for another patch.</pre> <br />
<p>- George</p>
<br />
<p>On June 8th, 2011, 12:23 p.m., George Goldberg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Telepathy.</div>
<div>By George Goldberg.</div>
<p style="color: grey;"><i>Updated June 8, 2011, 12:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix usage of deprecated tpqt4 signals.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">unit tests still pass</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>contact.cpp <span style="color: \
grey">(4a1c5c61a06446f8fde80df71a396022b658e545)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101541/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
KDE-Telepathy mailing list
KDE-Telepathy@kde.org
https://mail.kde.org/mailman/listinfo/kde-telepathy
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic