[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: KDE Frameworks 5.112.0
From:       David Faure <faure () kde ! org>
Date:       2023-11-06 22:16:54
Message-ID: 4232259.fBOqpY8iJ1 () asterixp15
[Download RAW message or body]


On lundi 6 novembre 2023 21:46:51 CET Albert Astals Cid wrote:
> Can you respin karchive to include my last commit in the kf5 branch?
> https://invent.kde.org/frameworks/karchive/-/commits/kf5

Hmm, there is very likely more code affected by this shared-mime-info \
change:

KF5:
knewstuff/src/core/installation.cpp:                    || \
                mimeType.inherits(QStringLiteral("application/x-bzip-compressed-tar"))
                
knewstuff/src/core/installation.cpp:                    || \
mimeType.inherits(QStringLiteral("application/x-bzip-compressed-tar")) || \
                mimeType.inherits(QStringLiteral("application/x-xz"))
kemoticons/src/core/kemoticons.cpp:               currentBundleMimeType == \
                QLatin1String("application/x-bzip-compressed-tar") ||
baloo/autotests/unit/file/basicindexingjobtest.cpp:     \
{QStringLiteral("test.tar.bz2"), \
QStringLiteral("application/x-bzip-compressed-tar"),               \
                {Type::Archive}},
kpackage/src/kpackage/package.cpp:               \
mimeType.inherits(QStringLiteral("application/x-bzip-compressed-tar")) || \
                //
kpackage/src/kpackage/private/packagejobthread.cpp:                   \
mimetype.inherits(QStringLiteral("application/x-bzip-compressed-tar")) || \
//

In kde/*:
workspace/sddm-kcm/sddmauthhelper.cpp:               || \
mimeType.inherits(QStringLiteral("application/x-xz")) || \
                mimeType.inherits(QStringLiteral("application/x-bzip-compressed-tar"))
                
workspace/plymouth-kcm/src/helper.cpp:        \
                QStringLiteral("application/x-bzip-compressed-tar"),
workspace/plymouth-kcm/src/kplymouththemeinstaller.cpp:            || \
mimeType.inherits(QStringLiteral("application/x-bzip-compressed-tar")) \
kdeutils/ark/README.md:| BZip-compressed TAR   | \
`application/x-bzip-compressed-tar`        |                                \
| kdeutils/ark/README.md:| BZip-compressed file      | `application/x-bzip` \
                |
kdeutils/ark/kerfuffle/mimetypes.cpp:        \
(mimeFromExtension.inherits(QStringLiteral("application/x-bzip-compressed-tar")) \
                &&
kdeutils/ark/plugins/libarchive/kerfuffle_libarchive.json.cmake:            \
                "application/x-bzip-compressed-tar",
kdeutils/ark/plugins/libarchive/kerfuffle_libarchive.json.cmake:    \
                "application/x-bzip-compressed-tar": {
kdeutils/ark/autotests/kerfuffle/mimetypetest.cpp:    const QString \
compressedBzip2TarMime = \
                QStringLiteral("application/x-bzip-compressed-tar");
kdenetwork/kget/ui/linkview/kget_sortfilterproxymodel.cpp:    \
QString("/x-7z-compressed,/x-ace,/x-archive,/x-arj,/x-bzip,/x-bzip-compressed-tar,/x-compressed-tar,/x-deb/,/x-rar,/x-tar,/x-rpm,/x-tarz,/zip");
                
kdenetwork/ktp-text-ui/adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp: \
currentBundleMimeType == QLatin1String("application/x-bzip-compressed-tar") \
                ||
kdenetwork/ktp-text-ui/lib/chat-window-style-manager.cpp:               \
currentBundleMimeType == QLatin1String("application/x-bzip-compressed-tar") \
                ||
kdenetwork/kio-extras/archive/archive.json:                \
                "application/x-bzip-compressed-tar",
applications/dolphin/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp: \
                "application/bzip-compressed",
applications/dolphin/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp: \
                "application/x-bzip-compressed",
applications/dolphin/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp: \
                "application/bzip-compressed-tar",
applications/dolphin/src/settings/contextmenu/servicemenuinstaller/servicemenuinstaller.cpp: \
                "application/x-bzip-compressed-tar",
applications/yakuake/app/config/appearancesettings.cpp:    mimeTypes << \
QStringLiteral("application/x-bzip-compressed-tar");

In extragear:
network/ktorrent/plugins/scripting/scriptmodel.cpp:        bool is_tar = \
ptr.name() == QStringLiteral("application/x-compressed-tar") || ptr.name() \
                == QStringLiteral("application/x-bzip-compressed-tar");
kdevelop/kdevelop/plugins/filetemplates/filetemplatesplugin.cpp:        \
                QStringLiteral("application/x-bzip-compressed-tar"),
kdevelop/kdevelop/plugins/appwizard/appwizardplugin.cpp:        \
                QStringLiteral("application/x-bzip-compressed-tar"),
kdevelop/kdevelop/plugins/appwizard/projectselectionpage.cpp:        \
                QStringLiteral("application/x-bzip-compressed-tar"),
kdevelop/kdevelop/plugins/filetemplates/templateselectionpage.cpp:        \
                QStringLiteral("application/x-bzip-compressed-tar"),
kdevelop/kdevplatform/plugins/appwizard/appwizardplugin.cpp:    types << \
                QStringLiteral("application/x-bzip-compressed-tar");
kdevelop/kdevplatform/plugins/appwizard/projectselectionpage.cpp:        \
                QStringLiteral("application/x-bzip-compressed-tar"),
kdevelop/kdevplatform/plugins/filetemplates/templateselectionpage.cpp:      \
                QStringLiteral("application/x-bzip-compressed-tar"),
kdevelop/kdevplatform/plugins/filetemplates/filetemplatesplugin.cpp:    \
                types << \
                QStringLiteral("application/x-bzip-compressed-tar");
utils/yakuake/app/config/appearancesettings.cpp:    mimeTypes << \
QStringLiteral("application/x-bzip-compressed-tar");

It looks like I need to go back to the shared-mime-info contributor and \
change s-m-i in a more source-compatible way. Usually our renamings \
introduce aliases, this one didn't because the goal was to separate bzip / \
bzip2 / bzip3, but we could still find a way (e.g. introduce "bzip1" and \
let bzip be an alias for bzip2...) Hopefully we can sort this out quick and \
release a new shared-mime-info before too many people use 2.3.... Got the \
ball rolling now in https://gitlab.freedesktop.org/xdg/shared-mime-info/-/merge_requests/239


-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]