[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Merge tags in master branch?
From: Ben Cooksley <bcooksley () kde ! org>
Date: 2020-11-28 21:21:16
Message-ID: CA+XidOEwkY3YyRrGcCS6Oc42bveGNoLjQopRYenvNLNt45fOWQ () mail ! gmail ! com
[Download RAW message or body]
On Sun, Nov 29, 2020 at 10:16 AM David Faure <faure@kde.org> wrote:
> On lundi 23 novembre 2020 16:11:02 CET Bhushan Shah wrote:
> > Hello,
> >
> > So I have one question regarding the how we do the framework versioning=
.
> > Namely the tags,
> >
> > So currently some packages have a versioned tags on their master branch=
,
> >
> > i.e
> >
> > karchive:
> >
> > =E2=9E=9C git describe
> > v5.76.0-1-g7304c28
> >
> > While in case of some frameworks where translations needs to be taken
> > from svn, it is something super weird like,
> >
> > kdesu:
> >
> > =E2=9E=9C git describe
> > v5.2.0-234-gb7ba89f
> >
> > Some packagers who package -git versions in their unstable repos check
> > the git describe to figure out what is current revision of the package
> > and having "wrong" version there bugs out weirdly.
>
> I know I'm doing something unusual with tags in KDE Frameworks
> (tags that are not part of a branch), but I'm surprised anyone would rely
> on
> `git describe` anyway, I've seen it being a bit unreliable/unexpected in
> the
> past (in non KDE repositories).
>
> > Do anyone have any opinion on "merging" latest git tag in master branch=
?
> > and potentially doing that for next releases as well?
>
> Merging the tag into master would work, I guess.
> One downside for KF5 developers is that the translated docbook files then
> have
> to be built. That's many screenfuls of things like
> [ 21%] Generating po/sr@latin/docs/kioslave5/webdav/index.cache.bz2
> which is just "noise" to developers, at least those who read the cmake
> output
> like I do ;-). And it might slow down compilation, I guess.
> You can check out v5.76.0 in kio to see what it looks like.
>
> Pushing translations every day as suggested by Harald creates the risk of
> a
> bad translation file breaking compilation. I remember catching that quite
> a
> few times when I started doing KF5 releases. But it hasn't happened for a
> long
> while so maybe there's now a git hook or something, to prevent that from
> happening?
>
Translations are still unfortunately located in SVN, and the hooks we have
for that have not changed in many, many years.
It's possible that scripty is performing some additional validation though
and correcting things there.
Cheers,
Ben
>
> --
> David Faure, faure@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>
>
[Attachment #3 (text/html)]
<div dir="ltr"><div dir="ltr">On Sun, Nov 29, 2020 at 10:16 AM David Faure <<a \
href="mailto:faure@kde.org">faure@kde.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote \
class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid \
rgb(204,204,204);padding-left:1ex">On lundi 23 novembre 2020 16:11:02 CET Bhushan Shah wrote:<br> > \
Hello,<br> > <br>
> So I have one question regarding the how we do the framework versioning.<br>
> Namely the tags,<br>
> <br>
> So currently some packages have a versioned tags on their master branch,<br>
> <br>
> i.e<br>
> <br>
> karchive:<br>
> <br>
> ➜ git describe<br>
> v5.76.0-1-g7304c28<br>
> <br>
> While in case of some frameworks where translations needs to be taken<br>
> from svn, it is something super weird like,<br>
> <br>
> kdesu:<br>
> <br>
> ➜ git describe<br>
> v5.2.0-234-gb7ba89f<br>
> <br>
> Some packagers who package -git versions in their unstable repos check<br>
> the git describe to figure out what is current revision of the package<br>
> and having "wrong" version there bugs out weirdly.<br>
<br>
I know I'm doing something unusual with tags in KDE Frameworks<br>
(tags that are not part of a branch), but I'm surprised anyone would rely on <br>
`git describe` anyway, I've seen it being a bit unreliable/unexpected in the <br>
past (in non KDE repositories).<br>
<br>
> Do anyone have any opinion on "merging" latest git tag in master branch?<br>
> and potentially doing that for next releases as well?<br>
<br>
Merging the tag into master would work, I guess.<br>
One downside for KF5 developers is that the translated docbook files then have <br>
to be built. That's many screenfuls of things like<br>
[ 21%] Generating po/sr@latin/docs/kioslave5/webdav/index.cache.bz2<br>
which is just "noise" to developers, at least those who read the cmake output <br>
like I do ;-). And it might slow down compilation, I guess.<br>
You can check out v5.76.0 in kio to see what it looks like.<br>
<br>
Pushing translations every day as suggested by Harald creates the risk of a <br>
bad translation file breaking compilation. I remember catching that quite a <br>
few times when I started doing KF5 releases. But it hasn't happened for a long <br>
while so maybe there's now a git hook or something, to prevent that from <br>
happening?<br></blockquote><div><br></div><div>Translations are still unfortunately located in SVN, and \
the hooks we have for that have not changed in many, many years.</div><div>It's possible that scripty \
is performing some additional validation though and correcting things \
there.</div><div><br></div><div>Cheers,</div><div>Ben</div><div> </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> <br>
-- <br>
David Faure, <a href="mailto:faure@kde.org" target="_blank">faure@kde.org</a>, <a \
href="http://www.davidfaure.fr" rel="noreferrer" target="_blank">http://www.davidfaure.fr</a><br> Working \
on KDE Frameworks 5<br> <br>
<br>
<br>
</blockquote></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic