[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: KDE Frameworks 5.76.0
From:       Caliste Damien <dcaliste () free ! fr>
Date:       2020-11-09 8:46:56
Message-ID: 20201109094656.74267bd9 () garulfo
[Download RAW message or body]

Hello,

Le dimanche 08 novembre 2020, Allen Winter a =C3=A9crit :
> @Damien: yes please. add a conditional compile check for libical
> 3.0.5 (better double-check that version)
Looking at when these new properties have been added in libical, I'm a
bit confused. It seems to me that they are present from 3.0.0.

They have been added in design-data/properties.csv by commit 7ca312deb
in 2016. I'm not familiar with libical internals, but as far as I
understand the CMakeList.txt in src/libical, the corresponding symbols
like icalproperty_new_color(), are created by the mkderivedproperty.pl
script that reads that design-data/properties.csv file. The v3.0.0 tag
is coming later than this commit 7ca312deb. I guess that I just need
then to use the USE_ICAL_3 CPP define in icalformat_p.cpp. Do you agree
?

Have a nice day,

Damien.
[prev in list] [next in list] [prev in thread] [next in thread]