[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Issue with Discover on the Plasma/5.14 branch
From:       David Edmundson <david () davidedmundson ! co ! uk>
Date:       2019-01-25 22:12:02
Message-ID: CAGeFrHC+43TJR9c0OZokOdtVR6s7J+Yc3sSw5Vt_LLgv=4=ZRw () mail ! gmail ! com
[Download RAW message or body]

My previous email missed the release team.

Fowarding:
Presumably also requires 4b6420596ca6a557591c24184a57b7985c77984e and more
importantly e8e3160cd20c11090572bd66337b41d9567bf461 from KNS which is a
whole new error reporting API with the error codes which you'd need

As it's new API any backported fix would need all that to be #ifdef'd, and
you'd still need the old code in a #else.
Do-able, but not as trivial as simply backporting something.

Given it's been broken forever, my gut reaction is that this is messy
enough to not be worth the risk of making things worse.
Or if you want a cheap hack, it might be worth looking at changing KNS's
legacy signal to emit Provider::signalError(""All categories are missing")
for network errors.

------

I've not seen a backportable patch.

[Attachment #3 (text/html)]

<div dir="ltr"><div><br></div><div>My previous email missed the release \
team.</div><div><br></div><div>Fowarding:</div><div><div dir="ltr"><div \
dir="ltr">Presumably also requires 4b6420596ca6a557591c24184a57b7985c77984e and more \
importantly e8e3160cd20c11090572bd66337b41d9567bf461 from KNS which is a whole new \
error reporting API with the error codes which you&#39;d need<br></div></div><div \
dir="ltr"><br></div><div>As it&#39;s new API any backported fix would need all that \
to be #ifdef&#39;d, and you&#39;d still need the old code in a \
#else.</div><div>Do-able, but not as trivial as simply backporting \
something.<br></div><div><br></div><div>Given it&#39;s been broken forever, my gut \
reaction is that this is messy enough to not be worth the risk of making things \
worse.<br></div><div>Or  if you want a cheap hack, it might  be worth looking at \
changing KNS&#39;s  legacy signal to emit Provider::signalError(&quot;&quot;All \
categories are  missing&quot;) for network \
errors.</div><div><br></div><div>------</div><div><br></div><div>I&#39;ve not seen a \
backportable patch. <br></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]