From kde-release-team  Tue Aug 16 14:11:31 2016
From: David Faure <faure () kde ! org>
Date: Tue, 16 Aug 2016 14:11:31 +0000
To: kde-release-team
Subject: Fwd: Re: Review Request 128697: Fix wrong value of __KDE_HAVE_GCC_VISIBILITY on systems with gcc 6.
Message-Id: <12089291.XxWyKcXJQx () asterixp50>
X-MARC-Message: https://marc.info/?l=kde-release-team&m=147135670122589

Packagers:=20
if you're using gcc 6, please integrate the fix below into your existing=20
kdelibs4 packages as soon as possible, given that it made linking of kde4 a=
pps=20
(creating shared libs) impossible on Fedora 24, Arch Linux, OpenSuSE=20
Tumbleweed, and probably others.
(symbols marked as exported, were not actually exported)

=2D---------  Forwarded Message  ----------

Subject: Re: Review Request 128697: Fix wrong value of=20
__KDE_HAVE_GCC_VISIBILITY on systems with gcc 6.
Date: mardi 16 ao=FBt 2016, 14:04:12 CEST
=46rom: David Faure <faure@kde.org>
To: Allen Winter <winter@kde.org>
CC: kdelibs <kde-core-devel@kde.org>, David Faure <faure@kde.org>



=2D----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128697/
=2D----------------------------------------------------------

(Updated Aug. 16, 2016, 2:04 p.m.)


Status
=2D-----

This change has been marked as submitted.


Review request for kdelibs and Allen Winter.


Changes
=2D------

Submitted with commit e9b25c7c040d8526fe8675b97d1067c8ffa7249f by David Fau=
re=20
to branch KDE/4.14.


Repository: kdelibs


Description
=2D------

Clearly the author of this regexp, in 2006, thought gcc would never
hit version 6 :-)


Diffs
=2D----

  cmake/modules/FindKDE4Internal.cmake=20
7d54b9b83b999f6a6e8541f8e8b89e0b2a105703=20

Diff: https://git.reviewboard.kde.org/r/128697/diff/


Testing
=2D------

Before:

kdemacros:/* #undef __KDE_HAVE_GCC_VISIBILITY */

After:

kdemacros.h:#define __KDE_HAVE_GCC_VISIBILITY


The impact of this was that symbols were no longer exported in shared libs=
=20
that use the KDE_EXPORT macro, thus breaking linking.


Thanks,

David Faure


=2D----------------------------------------
=2D-=20
David Faure, faure@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5