[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 128223: remove json, appdata and mimetype pos from applications tarball
From: Burkhard_Lück <lueck () hube-lueck ! de>
Date: 2016-06-21 12:17:20
Message-ID: 20160621121720.22783.92286 () mimi ! kde ! org
[Download RAW message or body]
--===============4977793683487647943==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Juni 19, 2016, 10:07 nachm., Albert Astals Cid wrote:
> > pack_l10n.sh, line 27
> > <https://git.reviewboard.kde.org/r/128223/diff/1/?file=469118#file469118line27>
> >
> > This really looks like a very broad naming to be deleting, nowadays we don't have \
> > any matching, but i could easily see something like kcm_mimetimes.pot at some \
> > point.
> > Maybe what we need to do is make scripty complain if he finds a *mimetype* file \
> > that it didn't generate?
>
> Burkhard Lück wrote:
> we should use a naming scheme indicating that a file is generated by scripty see \
> http://marc.info/?l=kde-i18n-doc&m=146640569414610&w=2
> Albert Astals Cid wrote:
> Agreed, do you want to wait until we agree on that?
we can use *xml_mimetypes.po, I doubt we will have a match with an application/plugin \
catalog
- Burkhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128223/#review96730
-----------------------------------------------------------
On Juni 20, 2016, 6:21 nachm., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128223/
> -----------------------------------------------------------
>
> (Updated Juni 20, 2016, 6:21 nachm.)
>
>
> Review request for Release Team and Albert Astals Cid.
>
>
> Repository: release-tools
>
>
> Description
> -------
>
> see summary
>
>
> Diffs
> -----
>
> pack_l10n.sh 5afa5e8
>
> Diff: https://git.reviewboard.kde.org/r/128223/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============4977793683487647943==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128223/">https://git.reviewboard.kde.org/r/128223/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Juni 19th, 2016, 10:07 nachm. UTC, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/128223/diff/1/?file=469118#file469118line27" \
style="color: black; font-weight: bold; text-decoration: underline;">pack_l10n.sh</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> rm -rf \
messages/*/*mimetypes*</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This really looks like a \
very broad naming to be deleting, nowadays we don't have any matching, but i \
could easily see something like kcm_mimetimes.pot at some point.
Maybe what we need to do is make scripty complain if he finds a *mimetype* file that \
it didn't generate?</pre> </blockquote>
<p>On Juni 20th, 2016, 6:22 nachm. UTC, <b>Burkhard Lück</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">we \
should use a naming scheme indicating that a file is generated by scripty see \
http://marc.info/?l=kde-i18n-doc&m=146640569414610&w=2</p></pre> \
</blockquote>
<p>On Juni 20th, 2016, 10:15 nachm. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Agreed, do you want to wait until we agree on that?</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">we can use \
*xml_mimetypes.po, I doubt we will have a match with an application/plugin \
catalog</pre> <br />
<p>- Burkhard</p>
<br />
<p>On Juni 20th, 2016, 6:21 nachm. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Release Team and Albert Astals Cid.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Juni 20, 2016, 6:21 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
release-tools
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see summary</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>pack_l10n.sh <span style="color: grey">(5afa5e8)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128223/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4977793683487647943==--
[Attachment #3 (text/plain)]
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic