[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 125544: Fix limit/offset handling when sort option is no sort.
From: "Xuetian Weng" <wengxt () gmail ! com>
Date: 2015-10-09 17:41:06
Message-ID: 20151009174106.17685.73802 () mimi ! kde ! org
[Download RAW message or body]
--===============0662389624090162250==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Oct. 9, 2015, 11:21 a.m., Vishesh Handa wrote:
> > src/lib/searchstore.cpp, line 103
> > <https://git.reviewboard.kde.org/r/125544/diff/1/?file=410212#file410212line103>
> >
> > Say we have 50 results
> >
> > limit = 10
> > offset = 5
> >
> > So we want results from [5, 14]
> >
> > With this code -
> > for (i = 5; i < 10; i++)
> >
> > We we would get [5, 10). Could you please fix this? I think a simple `i < limit + \
> > offset` would do.
>
> Xuetian Weng wrote:
> I just want to confirm, do we want [offset, offset + limit), or [offset, limit), \
> otherwise the semantics of sort looks problematic.
> Currently the sort is always applied to [0, limit), if we want [offset, offset + \
> limit), shouldn't we always sort the whole set, and then slice [offset, offset + \
> limit)?
For SQL, the query with ORDER BY will sort first, then slice the needed part of data.
- Xuetian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125544/#review86535
-----------------------------------------------------------
On Oct. 9, 2015, 11:21 a.m., Xuetian Weng wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125544/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2015, 11:21 a.m.)
>
>
> Review request for Baloo, Release Team and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> The bug is obvious, old code uses limit instead of (limit > 0), which gracefully \
> handles limit < 0 case (means everything).
> After offset is introduced, limit < 0 case is not handled properly.
>
> This patch contains following changes:
> 1. make offset uint, m_offset is uint in Query already.
> 2. handle limit < 0 case properly.
>
>
> Diffs
> -----
>
> src/lib/searchstore.h 17b4263
> src/lib/searchstore.cpp a2e7749
>
> Diff: https://git.reviewboard.kde.org/r/125544/diff/
>
>
> Testing
> -------
>
> baloosearch:/ doesn't return anything because of this, now it properly returns \
> result.
>
> Thanks,
>
> Xuetian Weng
>
>
--===============0662389624090162250==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125544/">https://git.reviewboard.kde.org/r/125544/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 9th, 2015, 11:21 a.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/125544/diff/1/?file=410212#file410212line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/searchstore.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">QStringList SearchStore::exec(const Term& term, int offset, int limit, bool \
sortResults)</pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; ">QStringList SearchStore::exec(const Term& term, uint offset, \
int limit, bool sortResults)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">for</span> <span class="p">(</span><span class="n">uint</span> <span \
class="n">i</span> <span class="o">=</span> <span class="n">offset</span><span \
class="p">;</span> <span class="n">i</span> <span class="o"><</span> <span \
class="k">static_cast</span><span class="o"><</span><span \
class="n">uint</span><span class="o">></span><span class="p">(</span><span \
class="n">limit</span><span class="p">);</span> <span class="n">i</span><span \
class="o">++</span><span class="p">)</span> <span class="p">{</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Say \
we have 50 results</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">limit = 10 offset = 5</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">So we want results from [5, 14]</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With \
this code - for (i = 5; i < 10; i++)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">We we would get [5, 10). Could you please fix this? I \
think a simple <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">i < limit + offset</code> \
would do.</p></pre> </blockquote>
<p>On October 9th, 2015, 5:37 p.m. UTC, <b>Xuetian Weng</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
just want to confirm, do we want [offset, offset + limit), or [offset, limit), \
otherwise the semantics of sort looks problematic.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Currently the sort is always applied to [0, limit), if we want [offset, \
offset + limit), shouldn't we always sort the whole set, and then slice [offset, \
offset + limit)?</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">For SQL, the query with ORDER BY will sort first, then slice the needed \
part of data.</p></pre> <br />
<p>- Xuetian</p>
<br />
<p>On October 9th, 2015, 11:21 a.m. UTC, Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Baloo, Release Team and Vishesh Handa.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Oct. 9, 2015, 11:21 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The bug is obvious, old code uses limit instead of \
(limit > 0), which gracefully handles limit < 0 case (means everything).</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">After offset is introduced, limit < 0 case is not handled properly.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch contains following changes: 1. make offset \
uint, m_offset is uint in Query already. 2. handle limit < 0 case \
properly.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">baloosearch:/ doesn't return anything because of this, \
now it properly returns result.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/searchstore.h <span style="color: grey">(17b4263)</span></li>
<li>src/lib/searchstore.cpp <span style="color: grey">(a2e7749)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125544/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0662389624090162250==--
[Attachment #3 (text/plain)]
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic