[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 123907: Make log viewer usable in multiple instances +
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-05-28 22:03:57
Message-ID: 20150528220357.31615.39081 () mimi ! kde ! org
[Download RAW message or body]
--===============7623960986728079435==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123907/
-----------------------------------------------------------
(Updated May 28, 2015, 10:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for Release Team and Telepathy.
Changes
-------
Submitted with commit 50a901a06733299af2238fc4c4d26d2f8052dae0 by Martin Klapetek to branch \
Applications/15.04.
Bugs: 346395
http://bugs.kde.org/show_bug.cgi?id=346395
Repository: ktp-text-ui
Description
-------
This fixes bug 346395 - when it is launched from Plasma, it will block all of Plasma until the app quits, \
which is announced by an error message box with that "KDEInit couldn't launch" error.
I'd like to commit this to stable too however this adds a new dependency on KDBusAddons. I think the \
severity of this issue warrants that new dependency, but can someone from the release team please ack \
this?
Additionally it makes it "Multiple" allowing for multiple running instances. I think it can be useful to \
eg. compare logs, but if anyone has a good reason for why it shouldn't be Multiple, please speak up.
Diffs
-----
CMakeLists.txt 72c2f8f
logviewer/CMakeLists.txt ac35ff6
logviewer/ktp-log-viewer.desktop 1674566
logviewer/main.cpp 00dbc03
logviewer/org.kde.ktplogviewer.desktop PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123907/diff/
Testing
-------
Plasma is no longer blocked when the log viewer is launched from Kicker.
Thanks,
Martin Klapetek
--===============7623960986728079435==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123907/">https://git.reviewboard.kde.org/r/123907/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; \
-moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Release Team and Telepathy.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 28, 2015, 10:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit \
50a901a06733299af2238fc4c4d26d2f8052dae0 by Martin Klapetek to branch Applications/15.04.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=346395">346395</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktp-text-ui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This fixes bug 346395 - when it is launched \
from Plasma, it will block all of Plasma until the app quits, which is announced by an error message box \
with that "KDEInit couldn't launch" error.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'd like to commit this to stable too however this adds a \
new dependency on KDBusAddons. I think the severity of this issue warrants that new dependency, but can \
someone from the release team please ack this?</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Additionally it makes it "Multiple" allowing for multiple \
running instances. I think it can be useful to eg. compare logs, but if anyone has a good reason for why \
it shouldn't be Multiple, please speak up.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Plasma is no longer blocked when the log \
viewer is launched from Kicker.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(72c2f8f)</span></li>
<li>logviewer/CMakeLists.txt <span style="color: grey">(ac35ff6)</span></li>
<li>logviewer/ktp-log-viewer.desktop <span style="color: grey">(1674566)</span></li>
<li>logviewer/main.cpp <span style="color: grey">(00dbc03)</span></li>
<li>logviewer/org.kde.ktplogviewer.desktop <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123907/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7623960986728079435==--
[Attachment #3 (text/plain)]
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic