[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request 119915: Plasma release scripts to use Ki18n's PO installation macro
From: "Harald Sitter" <sitter () kde ! org>
Date: 2014-08-25 7:02:08
Message-ID: 20140825070208.11205.44152 () probe ! kde ! org
[Download RAW message or body]
--===============6677299212815566160==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119915/#review65170
-----------------------------------------------------------
lib/kdel10n.rb
<https://git.reviewboard.kde.org/r/119915/#comment45518>
random nitpicking: could use @languages.empty? instead of a new var
lib/tests/ts_cmakeeditor.rb
<https://git.reviewboard.kde.org/r/119915/#comment45521>
Totally my bad. Please remove the return here when pushing :S
(test passes all the same)
The l10n test actually doesn't pass for me:
1) Failure:
TestL10n#test_get_po [./ts_l10n.rb:87]:
Failed assertion, no message given.
It appears that the test needs updating since we don't create a million \
cmakelists.txt anymore.
- Harald Sitter
On Aug. 24, 2014, 8:52 p.m., Chusslove Illich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119915/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2014, 8:52 p.m.)
>
>
> Review request for Release Team, Jonathan Riddell and Harald Sitter.
>
>
> Repository: releaseme
>
>
> Description
> -------
>
> At present, for installing Plasma PO files the release scripts create \
> CMakeLists.txt files inside po/ directory, which use CMake's \
> GETTEXT_PROCESS_PO_FILES. Ki18n instead provides the KI18N_INSTALL macro that only \
> needs to be called once from the top CMakeLists.txt, with po directory as argument. \
> This patch switches to using it.
> This is in preparation for updating release scripts to also fetch translation \
> scripting modules into the packages. Every PO file can have an associated scripting \
> module (though they are rare). KI18N_INSTALL handles these modules as well, when \
> they are found in expected location inside po/ directory.
>
> Diffs
> -----
>
> lib/cmakeeditor.rb 5465c99
> lib/kdel10n.rb f855de8
> lib/tests/ts_cmakeeditor.rb 9d7339f
>
> Diff: https://git.reviewboard.kde.org/r/119915/diff/
>
>
> Testing
> -------
>
> Run tarme.rb on couple of modules and languages, CMakeLists.txt tree got updated as \
> expected. Run ts_cmakeeditor.rb.
>
> Thanks,
>
> Chusslove Illich
>
>
--===============6677299212815566160==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119915/">https://git.reviewboard.kde.org/r/119915/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119915/diff/1/?file=307343#file307343line242" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/kdel10n.rb</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def \
get(sourceDirectory)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">240</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="n">anyTranslations</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">random nitpicking: could use @languages.empty? instead of a new \
var</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119915/diff/1/?file=307344#file307344line112" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/tests/ts_cmakeeditor.rb</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
def test_append_optional_add_subdirectory_substitute</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">112</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">99</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="k">return</span></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Totally my bad. Please remove the return here when pushing :S</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">(test passes all the same)</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
l10n test actually doesn't pass for me:</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">1) Failure:<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> TestL10n#test_get_po [./ts_l10n.rb:87]:<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
Failed assertion, no message given.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">It appears that the \
test needs updating since we don't create a million cmakelists.txt anymore.</p></pre>
<p>- Harald Sitter</p>
<br />
<p>On August 24th, 2014, 8:52 p.m. UTC, Chusslove Illich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Release Team, Jonathan Riddell and Harald Sitter.</div>
<div>By Chusslove Illich.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2014, 8:52 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
releaseme
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">At present, for installing Plasma PO files the release \
scripts create CMakeLists.txt files inside po/ directory, which use CMake's \
GETTEXT_PROCESS_PO_FILES. Ki18n instead provides the KI18N_INSTALL macro that only \
needs to be called once from the top CMakeLists.txt, with po directory as argument. \
This patch switches to using it.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This is in preparation \
for updating release scripts to also fetch translation scripting modules into the \
packages. Every PO file can have an associated scripting module (though they are \
rare). KI18N_INSTALL handles these modules as well, when they are found in expected \
location inside po/ directory.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Run tarme.rb on couple of modules and languages, \
CMakeLists.txt tree got updated as expected. Run ts_cmakeeditor.rb.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/cmakeeditor.rb <span style="color: grey">(5465c99)</span></li>
<li>lib/kdel10n.rb <span style="color: grey">(f855de8)</span></li>
<li>lib/tests/ts_cmakeeditor.rb <span style="color: grey">(9d7339f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119915/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6677299212815566160==--
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic