[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Minor fixes for Baloo
From: Albert Astals Cid <aacid () kde ! org>
Date: 2014-04-14 18:47:49
Message-ID: 3189228.jkO2ceJD29 () xps
[Download RAW message or body]
El Dilluns, 14 d'abril de 2014, a les 11:25:07, Vishesh Handa va escriure:
> Hey guys
>
> If it's not too much trouble, I'd like to get 2 patches into Baloo.
>
> One of them is this - https://git.reviewboard.kde.org/r/117420/
> It's a minor cosmetic change in the KCM. Considering the amount some users
> have complained about only having the folder name in the Desktop Search KCM,
> it might make sense to change it.
>
> The second is a minor crash fix which affects krunner.
>
> commit 798fbc52bbc5f5b8d1635eac90340e6f3aa6c374
> vlap:~/kde/src/baloo $ gl -p .
> commit 3fbb3df42f619f57d390327cf56da4120d9e4ed2
> Author: Vishesh Handa <me@vhanda.in>
> Date: Sat Apr 12 19:17:09 2014 +0200
>
> EmailSearchStore: Catch more exceptions
>
> BUG: 333351
>
> diff --git a/src/pim/search/email/emailsearchstore.cpp
> b/src/pim/search/email/emailsearchstore.cpp
> index 626cefc..6b0f267 100644
> --- a/src/pim/search/email/emailsearchstore.cpp
> +++ b/src/pim/search/email/emailsearchstore.cpp
> @@ -105,7 +105,7 @@ QString EmailSearchStore::text(int queryId)
> try {
> data = doc.get_data();
> }
> - catch (const Xapian::DatabaseError&) {
> + catch (const Xapian::Error&) {
> // Nothing to do, move along
> }
>
>
> Any objections?
Seems relatively safe to me and if they help giving a better impression of
Baloo I'm all for doing an exceptional retagging of Baloo.
Let's wait until tomorrow let's say 19:00 our time and if noone has complained
please commit to 4.13 and I'll retarball.
Cheers,
Albert
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic