'Re: Review Request 116558: Add KAccounts support to the dav resource'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request 116558: Add KAccounts support to the dav resource
From:       Àlex_Fiestas <afiestas () kde ! org>
Date:       2014-03-13 0:24:11
Message-ID: 20140313002411.14240.22280 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116558/
-----------------------------------------------------------

(Updated March 13, 2014, 12:24 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDEPIM, Release Team and Grégory Oestreicher.

Repository: kdepim-runtime

Description
-------

If compiled with KAccounts support and configure to use it, the resource will fetch \
credentials and host using libaccounts in order to build the urls.

Support for "editing" is not done, that will be done in 4.14 since it requires better \
kaccounts-integration.

To the release team, I would like to add this change to 4.13, it won't do anything \
except compiled with libaccounts and even so only if the resource is configured to \
use it.

Diffs
-----

  resources/dav/resource/CMakeLists.txt 14675bc 
  resources/dav/resource/davgroupwareresource.desktop 2342a01 
  resources/dav/resource/davgroupwareresource.kcfg 2d25371 
  resources/dav/resource/settings.h e264866 
  resources/dav/resource/settings.cpp 12f84cc 

Diff: https://git.reviewboard.kde.org/r/116558/diff/

Testing
-------

Thanks,

Àlex Fiestas

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116558/">https://git.reviewboard.kde.org/r/116558/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDEPIM, Release Team and Grégory Oestreicher.</div>
<div>By Àlex Fiestas.</div>

<p style="color: grey;"><i>Updated March 13, 2014, 12:24 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepim-runtime
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">If compiled with KAccounts support and configure to use it, the resource \
will fetch credentials and host using libaccounts in order to build the urls.

Support for &quot;editing&quot; is not done, that will be done in 4.14 since it \
requires better kaccounts-integration.

To the release team, I would like to add this change to 4.13, it won&#39;t do \
anything except compiled with libaccounts and even so only if the resource is \
configured to use it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>resources/dav/resource/CMakeLists.txt <span style="color: \
grey">(14675bc)</span></li>

 <li>resources/dav/resource/davgroupwareresource.desktop <span style="color: \
grey">(2342a01)</span></li>

 <li>resources/dav/resource/davgroupwareresource.kcfg <span style="color: \
grey">(2d25371)</span></li>

 <li>resources/dav/resource/settings.h <span style="color: \
grey">(e264866)</span></li>

 <li>resources/dav/resource/settings.cpp <span style="color: \
grey">(12f84cc)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116558/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 