'Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Review Request 115519: Do not use KDE_VERSION_STRING for workspace applications
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2014-02-06 15:51:36
Message-ID: 20140206155136.25665.31512 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115519/
-----------------------------------------------------------

Review request for kde-workspace and Release Team.

Repository: kde-workspace

Description
-------

Workspace is no longer synced with kdelibs releases. Thus if compiled
against e.g. 4.12 we want our workspace apps to still be 4.11.

Diffs
-----

  kwin/clients/oxygen/demo/main.cpp 83d9d83 
  kwrited/kwrited.cpp cab2d6b 
  plasma/desktop/shell/main.cpp ea3d43d 
  startkde.cmake 30d5ab5 
  statusnotifierwatcher/statusnotifierwatcher.cpp 97ae164 
  systemsettings/app/main.cpp 78109e0 
  kstyles/oxygen/config/main.cpp 5a5286e 
  kstyles/oxygen/demo/main.cpp 005395b 
  ksysguard/gui/ksysguard.cpp 2ad34f2 
  config-workspace.h.cmake b3ba37d 
  khotkeys/kcm_hotkeys/kcm_hotkeys.cpp 389a361 
  kinfocenter/main.cpp c28f7cf 
  krunner/main.cpp 6eac316 
  kscreensaver/kblank_screensaver/blankscrn.cpp 99ef649 
  kscreensaver/krandom_screensaver/random.cpp 4047184 

Diff: https://git.reviewboard.kde.org/r/115519/diff/

Testing
-------

compiled with 4.12.60 kdelibs and looked at e.g. startkde and systemsettings which have now 4.11.6.

Thanks,

Martin Gräßlin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115519/">https://git.reviewboard.kde.org/r/115519/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for kde-workspace and Release Team.</div>
<div>By Martin Gräßlin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Workspace is no longer synced with kdelibs releases. Thus if compiled \
against e.g. 4.12 we want our workspace apps to still be 4.11.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiled with 4.12.60 kdelibs and looked at e.g. startkde and \
systemsettings which have now 4.11.6.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kwin/clients/oxygen/demo/main.cpp <span style="color: \
grey">(83d9d83)</span></li>

 <li>kwrited/kwrited.cpp <span style="color: grey">(cab2d6b)</span></li>

 <li>plasma/desktop/shell/main.cpp <span style="color: grey">(ea3d43d)</span></li>

 <li>startkde.cmake <span style="color: grey">(30d5ab5)</span></li>

 <li>statusnotifierwatcher/statusnotifierwatcher.cpp <span style="color: \
grey">(97ae164)</span></li>

 <li>systemsettings/app/main.cpp <span style="color: grey">(78109e0)</span></li>

 <li>kstyles/oxygen/config/main.cpp <span style="color: grey">(5a5286e)</span></li>

 <li>kstyles/oxygen/demo/main.cpp <span style="color: grey">(005395b)</span></li>

 <li>ksysguard/gui/ksysguard.cpp <span style="color: grey">(2ad34f2)</span></li>

 <li>config-workspace.h.cmake <span style="color: grey">(b3ba37d)</span></li>

 <li>khotkeys/kcm_hotkeys/kcm_hotkeys.cpp <span style="color: \
grey">(389a361)</span></li>

 <li>kinfocenter/main.cpp <span style="color: grey">(c28f7cf)</span></li>

 <li>krunner/main.cpp <span style="color: grey">(6eac316)</span></li>

 <li>kscreensaver/kblank_screensaver/blankscrn.cpp <span style="color: \
grey">(99ef649)</span></li>

 <li>kscreensaver/krandom_screensaver/random.cpp <span style="color: \
grey">(4047184)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115519/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 