'Re: Review Request 110962: Switch to an external LibRaw'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request 110962: Switch to an external LibRaw
From:       "Commit Hook" <null () kde ! org>
Date:       2013-09-11 13:55:29
Message-ID: 20130911135529.2364.86864 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110962/
-----------------------------------------------------------

(Updated Sept. 11, 2013, 1:55 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Graphics, Release Team and Gilles Caulier.

Description
-------

Instead of using an embedded copy of LibRaw, look for an external LibRaw as mandatory \
dependency with a new CMake module and using its variables.  
Considering some LibRaw versions seem to be underlinked and not linking to OpenMP, \
link it manually in libkdcraw to overcome such lack.  
Switch back to the MAKE_KDCRAW_LIB define (i.e. the default set by KDE4_ADD_LIBRARY) \
as the one used to check whether it is being built, as otherwise LIBRAW_BUILDLIB \
would conflict with LibRaw.

Once this RR is approved, I will remove the libraw code copy and the CMake modules \
(FindLCMS2.cmake and FindPthreads.cmake) needed for it.

This addresses bug 307146.
    http://bugs.kde.org/show_bug.cgi?id=307146

Diffs
-----

  CMakeLists.txt f2f269609feb10947ec3bac10125b379c6c821dd 
  cmake/modules/FindLibRaw.cmake PRE-CREATION 
  libkdcraw/CMakeLists.txt cce5d6dba690fb5182638ccd1f10488bbd6ec2ce 
  libkdcraw/libkdcraw_export.h 1a222a03502a0e068bdba4f03b7ff4961c4a8f2b 

Diff: http://git.reviewboard.kde.org/r/110962/diff/

Testing
-------

Compiles fine with both LibRaw 0.14.7 and 0.15.1.

Thanks,

Pino Toscano

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110962/">http://git.reviewboard.kde.org/r/110962/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Graphics, Release Team and Gilles Caulier.</div>
<div>By Pino Toscano.</div>

<p style="color: grey;"><i>Updated Sept. 11, 2013, 1:55 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Instead of using an embedded copy of LibRaw, look for an external LibRaw \
as mandatory dependency with a new CMake module and using its variables.  
Considering some LibRaw versions seem to be underlinked and not linking to OpenMP, \
link it manually in libkdcraw to overcome such lack.  
Switch back to the MAKE_KDCRAW_LIB define (i.e. the default set by KDE4_ADD_LIBRARY) \
as the one used to check whether it is being built, as otherwise LIBRAW_BUILDLIB \
would conflict with LibRaw.

Once this RR is approved, I will remove the libraw code copy and the CMake modules \
(FindLCMS2.cmake and FindPthreads.cmake) needed for it.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Compiles fine with both LibRaw 0.14.7 and 0.15.1.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=307146">307146</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: \
grey">(f2f269609feb10947ec3bac10125b379c6c821dd)</span></li>

 <li>cmake/modules/FindLibRaw.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>libkdcraw/CMakeLists.txt <span style="color: \
grey">(cce5d6dba690fb5182638ccd1f10488bbd6ec2ce)</span></li>

 <li>libkdcraw/libkdcraw_export.h <span style="color: \
grey">(1a222a03502a0e068bdba4f03b7ff4961c4a8f2b)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110962/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 