[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: unifying libdiff2
From:       Jeremy Whiting <jpwhiting () kde ! org>
Date:       2013-07-24 22:12:15
Message-ID: CADWV2K7JMBECegNAzZLn3=rg_egP5_iNtMUFJMkxS68=za-5Hw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello Release team, a quick question.  I've split kompare/libdiff2 into
it's own git repository libkomparediff2 which builds on its own has all
branches/tags, etc. but need it to not be split for KDE SC 4.11 since
that's frozen anyway, so I guess I need to only merge my changes to kompare
to the master branch, and KDE/4.11 branch can be used to release KDE SC
4.11.x releases, right?

Kevin,
I've pushed my libkomparediff2 to the new official git repo, if you could
check it and kompare on my branch builds ok for you I'd appreciate it. then
I'll enable the hooks and do the other items on my list (make kdevplatform
use it, check the differences between the two copies, etc.

thanks,
Jeremy


On Sat, Jul 20, 2013 at 4:25 PM, Kevin Kofler <kevin.kofler@chello.at>wrote:

> Hi Jeremy,
>
> On Friday 19 July 2013 at 17:59:33, Jeremy Whiting wrote:
> > Thanks for the guidance.  I did decide the actions and such do belong
> > inside KompareModelList afterall, and found a way to make KomparePart get
> > the actions from the KompareModelList and add them to it's own
> > actionCollection.  I've pushed a branch to kompare called movelibdiff2 if
> > you want to take a look.  It works ok here, but I'll let you guys see
> what
> > you think of my solution.
> >
> > My libdiff2 is at scratch/whiting/libdiff2 and builds by itself and
> > installs a LibKompareDiff2Config.cmake file that libdialogpages on my
> > branch uses to find LibKompareDiff2 variables to build against.
>
> I looked at your changes, everything looks fine to me, so:
>
> Ship it!
>
>         Kevin Kofler
>

[Attachment #5 (text/html)]

<div dir="ltr">Hello Release team, a quick question.  I&#39;ve split kompare/libdiff2 \
into it&#39;s own git repository libkomparediff2 which builds on its own has all \
branches/tags, etc. but need it to not be split for KDE SC 4.11 since that&#39;s \
frozen anyway, so I guess I need to only merge my changes to kompare to the master \
branch, and KDE/4.11 branch can be used to release KDE SC 4.11.x releases, \
right?<div> <br></div><div>Kevin,</div><div>I&#39;ve pushed my libkomparediff2 to the \
new official git repo, if you could check it and kompare on my branch builds ok for \
you I&#39;d appreciate it. then I&#39;ll enable the hooks and do the other items on \
my list (make kdevplatform use it, check the differences between the two copies, \
etc.</div> <div><br></div><div>thanks,</div><div>Jeremy</div></div><div \
class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Jul 20, 2013 at 4:25 PM, \
Kevin Kofler <span dir="ltr">&lt;<a href="mailto:kevin.kofler@chello.at" \
target="_blank">kevin.kofler@chello.at</a>&gt;</span> wrote:<br> <blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi Jeremy,<br> <div class="im"><br>
On Friday 19 July 2013 at 17:59:33, Jeremy Whiting wrote:<br>
&gt; Thanks for the guidance.  I did decide the actions and such do belong<br>
&gt; inside KompareModelList afterall, and found a way to make KomparePart get<br>
&gt; the actions from the KompareModelList and add them to it&#39;s own<br>
&gt; actionCollection.  I&#39;ve pushed a branch to kompare called movelibdiff2 \
if<br> &gt; you want to take a look.  It works ok here, but I&#39;ll let you guys see \
what<br> &gt; you think of my solution.<br>
&gt;<br>
&gt; My libdiff2 is at scratch/whiting/libdiff2 and builds by itself and<br>
&gt; installs a LibKompareDiff2Config.cmake file that libdialogpages on my<br>
&gt; branch uses to find LibKompareDiff2 variables to build against.<br>
<br>
</div>I looked at your changes, everything looks fine to me, so:<br>
<br>
Ship it!<br>
<span class="HOEnZb"><font color="#888888"><br>
        Kevin Kofler<br>
</font></span></blockquote></div><br></div>



_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread]