[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request 110962: Switch to an external LibRaw
From:       Rolf Eike Beer <kde () opensource ! sf-tec ! de>
Date:       2013-06-12 6:39:45
Message-ID: 4680875.37kNUzZq5L () donald ! sf-tec ! de
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Vadim Zhukov wrote:

> cmake/modules/FindLibRaw.cmake
> <http://git.reviewboard.kde.org/r/110962/#comment25110>
> 
>     It's probably better to have own prefix for _version_* variables too,
> e.g.: "_libraw_version_major_match".

Pino already said that they are not indended to be used by anyone. And I 
already said that they should simply be unset after using then. Or if they are 
intended for using they should follow the CMake convention about naming them.

Eike
["signature.asc" (application/pgp-signature)]

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread]