[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request: Fix Save/Don't Save Button in Dialog on Exit, Fixes Regression compared to KDE 4
From: "Christoph Cullmann" <cullmann () kde ! org>
Date: 2013-01-03 20:10:56
Message-ID: 20130103201056.1675.37097 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Jan. 3, 2013, 8:07 p.m., Allen Winter wrote:
> > looks good to me. no objections, wearing my Release Team hat.
Ok, cherry picked the master commit to 4.10
http://commits.kde.org/kate/5fbd023fc46ecc57a6772be2aa04f532e8426f43
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108134/#review24610
-----------------------------------------------------------
On Jan. 3, 2013, 7:38 p.m., Christoph Cullmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108134/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2013, 7:38 p.m.)
>
>
> Review request for Kate and Release Team.
>
>
> Description
> -------
>
> Fixes problem that "save" and "don't save" buttons don't work in the dialog that \
> comes up on CTRL-Q if files are changed.
> https://bugs.kde.org/show_bug.cgi?id=311976
>
>
> Diffs
> -----
>
> kate/app/katesavemodifieddialog.cpp f249bd4
>
> Diff: http://git.reviewboard.kde.org/r/108134/diff/
>
>
> Testing
> -------
>
> Patched in master, compiles and works here.
>
>
> Thanks,
>
> Christoph Cullmann
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108134/">http://git.reviewboard.kde.org/r/108134/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On January 3rd, 2013, 8:07 p.m., <b>Allen \
Winter</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">looks good to me. no objections, wearing my Release Team hat.</pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, cherry picked the \
master commit to 4.10 \
http://commits.kde.org/kate/5fbd023fc46ecc57a6772be2aa04f532e8426f43</pre> <br />
<p>- Christoph</p>
<br />
<p>On January 3rd, 2013, 7:38 p.m., Christoph Cullmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Kate and Release Team.</div>
<div>By Christoph Cullmann.</div>
<p style="color: grey;"><i>Updated Jan. 3, 2013, 7:38 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes problem that "save" and "don't save" \
buttons don't work in the dialog that comes up on CTRL-Q if files are changed.
https://bugs.kde.org/show_bug.cgi?id=311976</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patched in master, compiles and works here.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kate/app/katesavemodifieddialog.cpp <span style="color: \
grey">(f249bd4)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108134/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic