[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Boost vs cmake 2.8.8 vs kdepimlibs master
From:       Alexander Neundorf <neundorf () kde ! org>
Date:       2012-12-16 16:54:34
Message-ID: 201212161754.34463.neundorf () kde ! org
[Download RAW message or body]

On Saturday 15 December 2012, Albert Astals Cid wrote:
> El Dissabte, 15 de desembre de 2012, a les 15:41:37, Alexander Neundorf va
> 
> escriure:
> > On Saturday 15 December 2012, Albert Astals Cid wrote:
> > > There seems to be various reports of kdepimlibs master not working with
> > > cmake 2.8.8
> > > 
> > > http://thread.gmane.org/gmane.comp.kde.devel.buildsystem/7589
> > > http://mail.kde.org/pipermail/release-team/2012-December/006566.html
> > > 
> > > But cmake 2.8.8 is what we are requiring at the global kdelibs level.
> > > 
> > > Should we:
> > >  a) Require cmake 2.8.9 at the kdelibs level
> > >  b) Require cmake 2.8.9 at the kdepimlibs level
> > >  c) Don't change requirement, bring back FindBoost.cmake to kdelibs and
> > > 
> > > keep working with 2.8.8
> > > 
> > > I don't have a strong feeling but i guess that "b" would actually imply
> > > "a"
> > > on 99.99% case of the packagers, so probaly just go with "a"?
> > > 
> > > Comments?
> > 
> > There would be also option
> > d) don't mark the package as REQUIRED in the summary, but simply do
> > find_package(Boost REQUIRED)
> > This should make it work too.
> 
> Interesting, if that works and saves us from increasing the dependency,
> might be worth a shot, can you provide a patch so people with cmake 2.8.8
> can give it a try?

Attached, can somebody give it a try ?

Alex

["make_boost_required.patch" (text/x-patch)]

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 0aea59c..332f4cf 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -66,8 +66,8 @@ configure_file(${CMAKE_SOURCE_DIR}/CTestCustom.cmake ${CMAKE_BINARY_DIR}/CTestCu
 ############### Find the stuff we need ###############
 
 set(Boost_MINIMUM_VERSION "1.34.0")
-find_package(Boost ${Boost_MINIMUM_VERSION} COMPONENTS graph)
-set_package_properties(Boost PROPERTIES DESCRIPTION "Boost C++ Libraries" URL "http://www.boost.org" \
TYPE REQUIRED PURPOSE "Boost must include the boost-graph library") +find_package(Boost \
${Boost_MINIMUM_VERSION} REQUIRED COMPONENTS graph) +set_package_properties(Boost PROPERTIES DESCRIPTION \
"Boost C++ Libraries" URL "http://www.boost.org" TYPE OPTIONAL PURPOSE "Boost must include the \
boost-graph library")  
 #FindGpgme.cmake already handles the log message but we must ensure it is required.
 find_package(Gpgme REQUIRED)



_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread]