From kde-release-team Fri Nov 30 20:24:48 2012 From: =?utf-8?q?Dennis_Nienh=C3=BCser?= Date: Fri, 30 Nov 2012 20:24:48 +0000 To: kde-release-team Subject: Re: Review Request: aprs: use external QextSerialPort for TTY reading Message-Id: <20121130202448.31886.88701 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-release-team&m=135430733715212 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4972627912158540207==" --===============4972627912158540207== Content-Type: multipart/alternative; boundary="===============4687144066857619242==" --===============4687144066857619242== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107536/ ----------------------------------------------------------- (Updated Nov. 30, 2012, 8:24 p.m.) Review request for kdewin, Marble, Release Team, and Wes Hardaker. Changes ------- Looks good to me, but I can't test it really lacking suitable hardware. I a= dded Wes (plugin's author) as a reviewer explicitly to get him notified abo= ut it. Description ------- Instead of embedding an (old) copy of the QextSerialPort library, find for = an external one; only if found enable the reading from TTY, which is otherw= ise disabled (leaving its configuration tab disabled). The drop of the internal QextSerialPort should also fix all the portability= issues, since the plugin itself does not use any OS-dependent API, and it = is then reenabled unconditionally. Hence, bug 241125 should now be fixed, and bug 237931 and bug 242039 should= not happen anymore. @release-team: yes, I know this would introduce a new optional dependency, = but on the other hand a copy of a 3rd party library would go away. Would th= is be acceptable at this point? This addresses bug 241125. http://bugs.kde.org/show_bug.cgi?id=3D241125 Diffs ----- cmake/modules/FindQextSerialPort.cmake PRE-CREATION = src/plugins/render/CMakeLists.txt d82293ee782e735ff1c90e6e13d330fb7cf8563= c = src/plugins/render/aprs/AprsPlugin.cpp f406cec2ad665977830416aa7f5df59851= a5e430 = src/plugins/render/aprs/AprsTTY.cpp c65ac38b24269b608c8f3ea1452b670f94221= 74d = src/plugins/render/aprs/CMakeLists.txt fb6ef13c80568a72a5bfcf8a2e675b9692= 38b9f6 = src/plugins/render/aprs/aprsconfig.h.in d0e6b5c4ce36080dc0e59422529c55728= ff04b3a = src/plugins/render/aprs/posix_qextserialport.cpp 118843f02a5c62fd708b9157= e59a039dff06e238 = src/plugins/render/aprs/qextserialport.h 457d831cffc4ae8c43ac7db2d85a2054= 6eb65044 = src/plugins/render/aprs/qextserialport.cpp 790e5a2701ba1291a645c4fd4b09a8= a1c55d7541 = src/plugins/render/aprs/qextserialport_global.h 013a6dcd4ecab97425b128613= 9af4f0e911c38c9 = src/plugins/render/aprs/win_qextserialport.cpp 5f21d7302e61b50825f79a68b3= 52d5b9544b3fa3 = Diff: http://git.reviewboard.kde.org/r/107536/diff/ Testing ------- The Aprs plugin compiles fine with and without an external QextSerialPort l= ibrary. Thanks, Pino Toscano --===============4687144066857619242== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/107536/

Review request for kdewin, Marble, Release Team, and Wes Hardaker.
By Pino Toscano.

Updated Nov. 30, 2012, 8:24 p.m.

Changes 
Looks good to me, but I can't test it really lacking sui=
table hardware. I added Wes (plugin's author) as a reviewer explicitly =
to get him notified about it.

Descripti= on 

Instead of embedding an (old) copy of the QextSerialPort lib=
rary, find for an external one; only if found enable the reading from TTY, =
which is otherwise disabled (leaving its configuration tab disabled).

The drop of the internal QextSerialPort should also fix all the portability=
 issues, since the plugin itself does not use any OS-dependent API, and it =
is then reenabled unconditionally.
Hence, bug 241125 should now be fixed, and bug 237931 and bug 242039 should=
 not happen anymore.

@release-team: yes, I know this would introduce a new optional dependency, =
but on the other hand a copy of a 3rd party library would go away. Would th=
is be acceptable at this point?

Testing <= /h1> 
The Aprs plugin compiles fine with and without an external Q=
extSerialPort library.
Bugs: 241125

Diffs=

  • cmake/modules/FindQextSerialPort.cmake (PR= E-CREATION)
  • src/plugins/render/CMakeLists.txt (d82293e= e782e735ff1c90e6e13d330fb7cf8563c)
  • src/plugins/render/aprs/AprsPlugin.cpp (f4= 06cec2ad665977830416aa7f5df59851a5e430)
  • src/plugins/render/aprs/AprsTTY.cpp (c65ac= 38b24269b608c8f3ea1452b670f9422174d)
  • src/plugins/render/aprs/CMakeLists.txt (fb= 6ef13c80568a72a5bfcf8a2e675b969238b9f6)
  • src/plugins/render/aprs/aprsconfig.h.in (d= 0e6b5c4ce36080dc0e59422529c55728ff04b3a)
  • src/plugins/render/aprs/posix_qextserialport.cpp (118843f02a5c62fd708b9157e59a039dff06e238)
  • src/plugins/render/aprs/qextserialport.h (= 457d831cffc4ae8c43ac7db2d85a20546eb65044)
  • src/plugins/render/aprs/qextserialport.cpp (790e5a2701ba1291a645c4fd4b09a8a1c55d7541)
  • src/plugins/render/aprs/qextserialport_global.h (013a6dcd4ecab97425b1286139af4f0e911c38c9)
  • src/plugins/render/aprs/win_qextserialport.cpp (5f21d7302e61b50825f79a68b352d5b9544b3fa3)

View Diff
--===============4687144066857619242==-- --===============4972627912158540207== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team --===============4972627912158540207==--