'Re: Review Request: Remove the Thing class'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request: Remove the Thing class
From:       "Vishesh Handa" <me () vhanda ! in>
Date:       2012-07-27 14:37:12
Message-ID: 20120727143712.2070.53042 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105755/
-----------------------------------------------------------

(Updated July 27, 2012, 2:37 p.m.)

Review request for Nepomuk, Release Team and Sebastian Trueg.

Changes
-------

@Release Team (Albert): Please please let me commit this. I hate old stupid=
 code. I'll have to live with it until we release KDE frameworks, that coul=
d be years away! If you have to choose any one of my patches to allow - THI=
S is the one to choose. The bug fixes can always go in 4.9.1. This cannot!

Thanks

Description
-------

No one uses it, and the same class can be generated using the rcgen. =

I don't see the point of having this class.

This is my last chance to remove this old code. Otherwise I'll have to wait=
 till KDE Frameworks 5.

Diffs
-----

  includes/CMakeLists.txt 4ac2d7c =

  includes/Thing 952544e =

  libnepomukcore/CMakeLists.txt 066c898 =

  libnepomukcore/resource/thing.h 2ae3d75 =

  libnepomukcore/resource/thing.cpp 59f2a4d =

Diff: http://git.reviewboard.kde.org/r/105755/diff/

Testing
-------

Thanks,

Vishesh Handa

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105755/">http://git.reviewboard.kde.org/r/105755/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk, Release Team and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated July 27, 2012, 2:37 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">@Release Team (Albert): Please please let me commit this. I hate old \
stupid code. I&#39;ll have to live with it until we release KDE frameworks, that \
could be years away! If you have to choose any one of my patches to allow - THIS is \
the one to choose. The bug fixes can always go in 4.9.1. This cannot!

Thanks</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No one uses it, and the same class can be generated using the rcgen.  I \
don&#39;t see the point of having this class.

This is my last chance to remove this old code. Otherwise I&#39;ll have to wait till \
KDE Frameworks 5.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>includes/CMakeLists.txt <span style="color: grey">(4ac2d7c)</span></li>

 <li>includes/Thing <span style="color: grey">(952544e)</span></li>

 <li>libnepomukcore/CMakeLists.txt <span style="color: grey">(066c898)</span></li>

 <li>libnepomukcore/resource/thing.h <span style="color: grey">(2ae3d75)</span></li>

 <li>libnepomukcore/resource/thing.cpp <span style="color: \
grey">(59f2a4d)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105755/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 