From kde-release-team  Tue Jul 10 16:29:50 2012
From: "Vishesh Handa" <me () vhanda ! in>
Date: Tue, 10 Jul 2012 16:29:50 +0000
To: kde-release-team
Subject: Re: Review Request: Fix crash in nepomuk services after a timeout
Message-Id: <20120710162950.27611.21541 () vidsolbach ! de>
X-MARC-Message: https://marc.info/?l=kde-release-team&m=134194938514164
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1137053090705593241=="

--===============1137053090705593241==
Content-Type: multipart/alternative;
	boundary="===============2863559859495883837=="

--===============2863559859495883837==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105507/#review15632
-----------------------------------------------------------

Ship it!


Could you please add a FIXME in the comment? Just so that it becomes more o=
bvious.

- Vishesh Handa


On July 10, 2012, 3:57 p.m., David Faure wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105507/
> -----------------------------------------------------------
> =

> (Updated July 10, 2012, 3:57 p.m.)
> =

> =

> Review request for Nepomuk and Release Team.
> =

> =

> Description
> -------
> =

> Fix crash due to other threads using the model at the time it gets delete=
d. No proper solution found though, with the current API.
> =

> =

> Diffs
> -----
> =

>   libnepomukcore/resource/nepomukmainmodel.cpp ba2626f =

> =

> Diff: http://git.reviewboard.kde.org/r/105507/diff/
> =

> =

> Testing
> -------
> =

> Running nepomukqueryservice in valgrind gave this:
> =

> "/d/kde/inst/kde4.9/bin/nepomukservicestub(19732)" Soprano: "Timeout (5)"=
: "Command timed out."
> =3D=3D19732=3D=3D Thread 3:
> =3D=3D19732=3D=3D Invalid read of size 8
> =3D=3D19732=3D=3D    at 0xC5AB6DA: QPointer<Soprano::Client::ClientConnec=
tion>::operator->() const (qpointer.h:74)
> =3D=3D19732=3D=3D    by 0xC5AA70A: Soprano::Client::ClientModel::executeQ=
uery(QString const&, Soprano::Query::QueryLanguage, QString const&) const (=
clientmodel.cpp:106)
> =3D=3D19732=3D=3D    by 0x68E9319: Nepomuk2::MainModel::executeQuery(QStr=
ing const&, Soprano::Query::QueryLanguage, QString const&) const (nepomukma=
inmodel.cpp:182)
> =3D=3D19732=3D=3D    by 0x12BDDEED: Nepomuk2::Query::SearchRunnable::run(=
) (searchrunnable.cpp:89)
> =3D=3D19732=3D=3D    by 0x4ECA2FC: QThreadPoolThread::run() (qthreadpool.=
cpp:107)
> =3D=3D19732=3D=3D    by 0x4EDAF27: QThreadPrivate::start(void*) (qthread_=
unix.cpp:307)
> =3D=3D19732=3D=3D    by 0x53CCF04: start_thread (in /lib64/libpthread-2.1=
4.1.so)
> =3D=3D19732=3D=3D    by 0x86CD10C: clone (in /lib64/libc-2.14.1.so)
> =3D=3D19732=3D=3D  Address 0x117af938 is 72 bytes inside a block of size =
80 free'd
> =3D=3D19732=3D=3D    at 0x4C28706: operator delete(void*) (vg_replace_mal=
loc.c:457)
> =3D=3D19732=3D=3D    by 0xC5AA2ED: Soprano::Client::ClientModel::~ClientM=
odel() (clientmodel.cpp:58)
> =3D=3D19732=3D=3D    by 0x68E8BAB: (anonymous namespace)::GlobalModelCont=
ainer::init(bool) (nepomukmainmodel.cpp:82)
> =3D=3D19732=3D=3D    by 0x68E8E58: (anonymous namespace)::GlobalModelCont=
ainer::model() (nepomukmainmodel.cpp:100)
> =3D=3D19732=3D=3D    by 0x68E932D: Nepomuk2::MainModel::executeQuery(QStr=
ing const&, Soprano::Query::QueryLanguage, QString const&) const (nepomukma=
inmodel.cpp:183)
> =3D=3D19732=3D=3D    by 0x12BDDEED: Nepomuk2::Query::SearchRunnable::run(=
) (searchrunnable.cpp:89)
> =3D=3D19732=3D=3D    by 0x4ECA2FC: QThreadPoolThread::run() (qthreadpool.=
cpp:107)
> =3D=3D19732=3D=3D    by 0x4EDAF27: QThreadPrivate::start(void*) (qthread_=
unix.cpp:307)
> =3D=3D19732=3D=3D    by 0x53CCF04: start_thread (in /lib64/libpthread-2.1=
4.1.so)
> =3D=3D19732=3D=3D    by 0x86CD10C: clone (in /lib64/libc-2.14.1.so)
> =3D=3D19732=3D=3D =

> =

> No crash anymore after this "fix"...
> =

> =

> Thanks,
> =

> David Faure
> =

>


--===============2863559859495883837==
Content-Type: text/html; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable




<html>
 <body>
  <div style=3D"font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor=3D"#f9f3c9" width=3D"100%" cellpadding=3D"8" style=3D"bor=
der: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href=3D"http://git.reviewboard.kde.org/r/105507/">http://git.revie=
wboard.kde.org/r/105507/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style=3D"white-space: pre-wrap; white-space: -moz-pre-wrap; white-spa=
ce: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you =
please add a FIXME in the comment? Just so that it becomes more obvious.</p=
re>
 <br />







<p>- Vishesh</p>


<br />
<p>On July 10th, 2012, 3:57 p.m., David Faure wrote:</p>






<table bgcolor=3D"#fefadf" width=3D"100%" cellspacing=3D"0" cellpadding=3D"=
8" style=3D"background-image: url('http://git.reviewboard.kde.org/media/rb/=
images/review_request_box_top_bg.png'); background-position: left top; back=
ground-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Nepomuk and Release Team.</div>
<div>By David Faure.</div>


<p style=3D"color: grey;"><i>Updated July 10, 2012, 3:57 p.m.</i></p>






<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Descripti=
on </h1>
 <table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D=
"10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Fix crash due to other threads using the model at the time i=
t gets deleted. No proper solution found though, with the current API.</pre>
  </td>
 </tr>
</table>


<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing <=
/h1>
<table width=3D"100%" bgcolor=3D"#ffffff" cellspacing=3D"0" cellpadding=3D"=
10" style=3D"border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style=3D"margin: 0; padding: 0; white-space: pre-wrap; white-space:=
 -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap=
: break-word;">Running nepomukqueryservice in valgrind gave this:

&quot;/d/kde/inst/kde4.9/bin/nepomukservicestub(19732)&quot; Soprano: &quot=
;Timeout (5)&quot;: &quot;Command timed out.&quot;
=3D=3D19732=3D=3D Thread 3:
=3D=3D19732=3D=3D Invalid read of size 8
=3D=3D19732=3D=3D    at 0xC5AB6DA: QPointer&lt;Soprano::Client::ClientConne=
ction&gt;::operator-&gt;() const (qpointer.h:74)
=3D=3D19732=3D=3D    by 0xC5AA70A: Soprano::Client::ClientModel::executeQue=
ry(QString const&amp;, Soprano::Query::QueryLanguage, QString const&amp;) c=
onst (clientmodel.cpp:106)
=3D=3D19732=3D=3D    by 0x68E9319: Nepomuk2::MainModel::executeQuery(QStrin=
g const&amp;, Soprano::Query::QueryLanguage, QString const&amp;) const (nep=
omukmainmodel.cpp:182)
=3D=3D19732=3D=3D    by 0x12BDDEED: Nepomuk2::Query::SearchRunnable::run() =
(searchrunnable.cpp:89)
=3D=3D19732=3D=3D    by 0x4ECA2FC: QThreadPoolThread::run() (qthreadpool.cp=
p:107)
=3D=3D19732=3D=3D    by 0x4EDAF27: QThreadPrivate::start(void*) (qthread_un=
ix.cpp:307)
=3D=3D19732=3D=3D    by 0x53CCF04: start_thread (in /lib64/libpthread-2.14.=
1.so)
=3D=3D19732=3D=3D    by 0x86CD10C: clone (in /lib64/libc-2.14.1.so)
=3D=3D19732=3D=3D  Address 0x117af938 is 72 bytes inside a block of size 80=
 free&#39;d
=3D=3D19732=3D=3D    at 0x4C28706: operator delete(void*) (vg_replace_mallo=
c.c:457)
=3D=3D19732=3D=3D    by 0xC5AA2ED: Soprano::Client::ClientModel::~ClientMod=
el() (clientmodel.cpp:58)
=3D=3D19732=3D=3D    by 0x68E8BAB: (anonymous namespace)::GlobalModelContai=
ner::init(bool) (nepomukmainmodel.cpp:82)
=3D=3D19732=3D=3D    by 0x68E8E58: (anonymous namespace)::GlobalModelContai=
ner::model() (nepomukmainmodel.cpp:100)
=3D=3D19732=3D=3D    by 0x68E932D: Nepomuk2::MainModel::executeQuery(QStrin=
g const&amp;, Soprano::Query::QueryLanguage, QString const&amp;) const (nep=
omukmainmodel.cpp:183)
=3D=3D19732=3D=3D    by 0x12BDDEED: Nepomuk2::Query::SearchRunnable::run() =
(searchrunnable.cpp:89)
=3D=3D19732=3D=3D    by 0x4ECA2FC: QThreadPoolThread::run() (qthreadpool.cp=
p:107)
=3D=3D19732=3D=3D    by 0x4EDAF27: QThreadPrivate::start(void*) (qthread_un=
ix.cpp:307)
=3D=3D19732=3D=3D    by 0x53CCF04: start_thread (in /lib64/libpthread-2.14.=
1.so)
=3D=3D19732=3D=3D    by 0x86CD10C: clone (in /lib64/libc-2.14.1.so)
=3D=3D19732=3D=3D =


No crash anymore after this &quot;fix&quot;...</pre>
  </td>
 </tr>
</table>




<h1 style=3D"color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b>=
 </h1>
<ul style=3D"margin-left: 3em; padding-left: 0;">

 <li>libnepomukcore/resource/nepomukmainmodel.cpp <span style=3D"color: gre=
y">(ba2626f)</span></li>

</ul>

<p><a href=3D"http://git.reviewboard.kde.org/r/105507/diff/" style=3D"margi=
n-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>


--===============2863559859495883837==--

--===============1137053090705593241==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

--===============1137053090705593241==--