'Re: Review Request: ResourceManager: Do not double initalize the NepomukMainModel'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Review Request: ResourceManager: Do not double initalize the NepomukMainModel
From:       "Commit Hook" <null () kde ! org>
Date:       2012-07-03 12:19:22
Message-ID: 20120703121922.10795.29616 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105281/#review15338
-----------------------------------------------------------

This review has been submitted with commit 847d642f876507bda220750468afbba3=
adbccbfa by Vishesh Handa to branch KDE/4.9.

- Commit Hook

On June 26, 2012, 9:06 a.m., Vishesh Handa wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105281/
> -----------------------------------------------------------
> =

> (Updated June 26, 2012, 9:06 a.m.)
> =

> =

> Review request for Nepomuk, Release Team and Sebastian Trueg.
> =

> =

> Description
> -------
> =

> ResourceManager: Do not double initalize the NepomukMainModel
> =

> The NepomukMainModel is initalized once when it is created and then the
> second time in ResourceManager::init.
> =

> This results in a second connection being made to nepomukstorage, and an
> extra thread being spawned over there. The old thread is eventually
> deleted, but the whole process is rather pointless.
> =

> =

> Diffs
> -----
> =

>   libnepomukcore/resource/nepomukmainmodel.cpp a11faae9a6d42806ba884e74f0=
7e2d0113c6910f =

> =

> Diff: http://git.reviewboard.kde.org/r/105281/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Vishesh Handa
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105281/">http://git.reviewboard.kde.org/r/105281/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 847d642f876507bda220750468afbba3adbccbfa by Vishesh Handa to \
branch KDE/4.9.</pre>  <br />

<p>- Commit</p>

<br />
<p>On June 26th, 2012, 9:06 a.m., Vishesh Handa wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Nepomuk, Release Team and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>

<p style="color: grey;"><i>Updated June 26, 2012, 9:06 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ResourceManager: Do not double initalize the NepomukMainModel

The NepomukMainModel is initalized once when it is created and then the
second time in ResourceManager::init.

This results in a second connection being made to nepomukstorage, and an
extra thread being spawned over there. The old thread is eventually
deleted, but the whole process is rather pointless.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libnepomukcore/resource/nepomukmainmodel.cpp <span style="color: \
grey">(a11faae9a6d42806ba884e74f07e2d0113c6910f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105281/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team

[prev in list] [next in list] [prev in thread] [next in thread] 