[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-release-team
Subject: Re: Review Request: ResourceManager: Do not double initalize the NepomukMainModel
From: "Albert Astals Cid" <tsdgeos () terra ! es>
Date: 2012-06-26 19:43:31
Message-ID: 20120626194331.14001.66007 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 26, 2012, 9:55 a.m., Albert Astals Cid wrote:
> > To be honest i'd prefer you commit this to the KDE/4.9 branch after RC1=
is released, as you say it's not critical (nothing breaks), so i don't rea=
lly see the point on breaking the RC freeze.
> =
> Vishesh Handa wrote:
> Oh, you mean one can commit stuff normally after RC1 has been release=
d? I was under the impression that all commits after RC1, till the final re=
lease need to go through the reviewboard.
> =
> Cool, then I'll wait. And I won't have to add the release team for al=
l my commits.
Yes, the freeze is only today for RC1 tagging and the day of RC2 tagging, o=
ut of that normal rules apply.
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105281/#review15161
-----------------------------------------------------------
On June 26, 2012, 9:06 a.m., Vishesh Handa wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105281/
> -----------------------------------------------------------
> =
> (Updated June 26, 2012, 9:06 a.m.)
> =
> =
> Review request for Nepomuk, Release Team and Sebastian Trueg.
> =
> =
> Description
> -------
> =
> ResourceManager: Do not double initalize the NepomukMainModel
> =
> The NepomukMainModel is initalized once when it is created and then the
> second time in ResourceManager::init.
> =
> This results in a second connection being made to nepomukstorage, and an
> extra thread being spawned over there. The old thread is eventually
> deleted, but the whole process is rather pointless.
> =
> =
> Diffs
> -----
> =
> libnepomukcore/resource/nepomukmainmodel.cpp a11faae9a6d42806ba884e74f0=
7e2d0113c6910f =
> =
> Diff: http://git.reviewboard.kde.org/r/105281/diff/
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Vishesh Handa
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105281/">http://git.reviewboard.kde.org/r/105281/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <p style="margin-top: 0;">On June 26th, 2012, 9:55 \
a.m., <b>Albert Astals Cid</b> wrote:</p> <blockquote style="margin-left: \
1em; border-left: 2px solid #d0d0d0; padding-left: 10px;"> <pre \
style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To be honest \
i'd prefer you commit this to the KDE/4.9 branch after RC1 is released, \
as you say it's not critical (nothing breaks), so i don't really \
see the point on breaking the RC freeze.</pre> </blockquote>
<p>On June 26th, 2012, 10:09 a.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Oh, you mean one can commit stuff normally after RC1 has been \
released? I was under the impression that all commits after RC1, till the \
final release need to go through the reviewboard.
Cool, then I'll wait. And I won't have to add the release team for \
all my commits.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, the \
freeze is only today for RC1 tagging and the day of RC2 tagging, out of \
that normal rules apply.</pre> <br />
<p>- Albert</p>
<br />
<p>On June 26th, 2012, 9:06 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;"> <tr>
<td>
<div>Review request for Nepomuk, Release Team and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 26, 2012, 9:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ResourceManager: Do not double initalize the NepomukMainModel
The NepomukMainModel is initalized once when it is created and then the
second time in ResourceManager::init.
This results in a second connection being made to nepomukstorage, and an
extra thread being spawned over there. The old thread is eventually
deleted, but the whole process is rather pointless.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>libnepomukcore/resource/nepomukmainmodel.cpp <span style="color: \
grey">(a11faae9a6d42806ba884e74f07e2d0113c6910f)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105281/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic