From kde-release-team Sat Dec 03 14:52:24 2011 From: "Albert Astals Cid" Date: Sat, 03 Dec 2011 14:52:24 +0000 To: kde-release-team Subject: Re: Review Request: Add git support to kdesdk: create_tarball.rb Message-Id: <20111203145224.27110.36205 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-release-team&m=132292405223855 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5884789393615826890==" --===============5884789393615826890== Content-Type: multipart/alternative; boundary="===============0932772420157559926==" --===============0932772420157559926== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6842/#review10511 ----------------------------------------------------------- Ship it! The changes seem very minor, and from what i can see they will not "break" = the svn support, so just go for it if it works for you. = We can fix any new issues in git support as they arise. - Albert Astals Cid On Nov. 29, 2011, 4:42 p.m., K=C3=A5re S=C3=A4rs wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6842/ > ----------------------------------------------------------- > = > (Updated Nov. 29, 2011, 4:42 p.m.) > = > = > Review request for kdelibs and Release Team. > = > = > Description > ------- > = > This patch adds git support to create_tarball.rb in kdesdk. The patch add= s two options to the ini file. The first one (gitModule) indicates that the= module is located in git and the second optional parameter (gitTag) define= s which tag to use for creating the release. (there is no group for kdesdk = or extragear) > = > = > Diffs > ----- > = > trunk/KDE/kdesdk/scripts/createtarball/config.ini 1266277 = > trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb 1266277 = > = > Diff: http://svn.reviewboard.kde.org/r/6842/diff/diff > = > = > Testing > ------- > = > = > Thanks, > = > K=C3=A5re S=C3=A4rs > = > --===============0932772420157559926== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6842/

Ship it!

The change=
s seem very minor, and from what i can see they will not "break" =
the svn support, so just go for it if it works for you. =


We can fix any new issues in git support as they arise.

- Albert

On November 29th, 2011, 4:42 p.m., K=C3=A5re S=C3=A4rs wrote:

Review request for kdelibs and Release Team.

By K=C3=A5re S=C3=A4rs.

Updated Nov. 29, 2011, 4:42 p.m.

Descripti= on

This patch adds git support to create_tarball.rb in kdesdk. =
The patch adds two options to the ini file. The first one (gitModule) indic=
ates that the module is located in git and the second optional parameter (g=
itTag) defines which tag to use for creating the release. (there is no grou=
p for kdesdk or extragear)

Diffs=

trunk/KDE/kdesdk/scripts/createtarball/config.ini (1266277)
trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb (1266277)

View Diff

--===============0932772420157559926==-- --===============5884789393615826890== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ release-team mailing list release-team@kde.org https://mail.kde.org/mailman/listinfo/release-team --===============5884789393615826890==--