[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: Forgot to backport changes in kde-runtime
From:       Vishesh Handa <handa.vish () gmail ! com>
Date:       2011-07-25 15:56:36
Message-ID: CAKb-1ods-nbW28gAeifU-tzLTzd-tu5+122kzsdSVf1U1Gvg=Q () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, Jul 25, 2011 at 9:08 PM, Rex Dieter <rdieter@math.unl.edu> wrote:

> On 07/25/2011 10:26 AM, Vishesh Handa wrote:
>
>> Hey Release team
>>
>> I'd posted on the list about 10 days ago about the need to backport a
>> lot of Nepomuk commits. One of which was extremely important and fixed
>> file indexing. ( The others were very trivial stuff that didn't really
>> matter ). I apparently forgot to push that one important commit. ( Yes,
>> I'm an idiot! )
>>
>> Could you guys please repackage kde-runtime? I've just backported the
>> commits.
>>
>
> for posterity, what commit(s) precisely?
>

Commit - ebaf3b457b94a8be7a894b8eed81940cb7bb818f and its unit test
95f65b882149d398553e8934318658301c84dd29

The unit test doesn't really matter.

I'm copy pasting the commit message -

commit ebaf3b457b94a8be7a894b8eed81940cb7bb818f
Author: Vishesh Handa <handa.vish@gmail.com>
Date:   Tue Jul 12 14:56:17 2011 +0530

    Improve storeResources file resolution

    This patch does three things -
    1. Use QUrl::toLocalFile, when testing if the url exists using QFileInfo
    2. Before resolving all the url present in the objects. Convert them
       from the QVariant into Soprano::Node using the ClassAndPropertyTree,
       this way based on the type, the variant is converted to the correct
       node. Resolution is a lot simpler ( and correct ) this way.
    3. Fix SyncResource blank node handling - When blank nodes are stored
       as QUrls they should be stored as "_:identifier" not "identifier"

    This fixes testStoreResources_folder ( and strigi indexing )


> -- rex
>



-- 
Vishesh Handa

[Attachment #5 (text/html)]

<br><br><div class="gmail_quote">On Mon, Jul 25, 2011 at 9:08 PM, Rex Dieter <span \
dir="ltr">&lt;<a href="mailto:rdieter@math.unl.edu">rdieter@math.unl.edu</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex;"> <div class="im">On 07/25/2011 10:26 AM, Vishesh Handa \
wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"> Hey Release team<br>
<br>
I&#39;d posted on the list about 10 days ago about the need to backport a<br>
lot of Nepomuk commits. One of which was extremely important and fixed<br>
file indexing. ( The others were very trivial stuff that didn&#39;t really<br>
matter ). I apparently forgot to push that one important commit. ( Yes,<br>
I&#39;m an idiot! )<br>
<br>
Could you guys please repackage kde-runtime? I&#39;ve just backported the<br>
commits.<br>
</blockquote>
<br></div>
for posterity, what commit(s) precisely?<br></blockquote><div><br>Commit - \
ebaf3b457b94a8be7a894b8eed81940cb7bb818f and its unit test \
95f65b882149d398553e8934318658301c84dd29 <br><br>The unit test doesn&#39;t really \
matter. <br> <br>I&#39;m copy pasting the commit message - <br><br>commit \
ebaf3b457b94a8be7a894b8eed81940cb7bb818f<br>Author: Vishesh Handa &lt;<a \
href="mailto:handa.vish@gmail.com">handa.vish@gmail.com</a>&gt;<br>Date:   Tue Jul 12 \
14:56:17 2011 +0530<br> <br>    Improve storeResources file resolution<br>    <br>    \
This patch does three things -<br>    1. Use QUrl::toLocalFile, when testing if the \
url exists using QFileInfo<br>    2. Before resolving all the url present in the \
objects. Convert them<br>  from the QVariant into Soprano::Node using the \
ClassAndPropertyTree,<br>       this way based on the type, the variant is converted \
to the correct<br>       node. Resolution is a lot simpler ( and correct ) this \
way.<br>  3. Fix SyncResource blank node handling - When blank nodes are stored<br>   \
as QUrls they should be stored as &quot;_:identifier&quot; not \
&quot;identifier&quot;<br>    <br>    This fixes testStoreResources_folder ( and \
strigi indexing )<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt \
0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"><font \
color="#888888"> <br>
-- rex<br>
</font></blockquote></div><br><br clear="all"><br>-- <br><font \
color="#999999">Vishesh Handa</font><br>



_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread]