[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-release-team
Subject:    Re: kdebase runtime ioslave freeze exemption request
From:       Olivier Goffart <ogoffart () kde ! org>
Date:       2009-05-11 22:55:05
Message-ID: 200905120055.12214.ogoffart () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Le Mandag 11 mai 2009, Helio Chissini de Castro a écrit  :
> Hello guys !
>
> Since I've got in the middle of the release of Mandriva 2009 Spring, i
> totally forgot the effective base part of lzma patch.
>
> So, attached is the kdebase-runtime patch, it contains no new string in
> code, but has their own doc and .desktop files, which is a translation
> issue. Since is a brand new thing and not touch any of current components
> functionality, i would like to request if is possible acceptance of this
> one.

I haven't checked the documentaton, but for the code:


> Index: kioslave/man/kio_man.cpp
> ===================================================================
> --- kioslave/man/kio_man.cpp        (revisão 966710)
> +++ kioslave/man/kio_man.cpp        (cópia de trabalho)
> @@ -70,6 +70,10 @@
>               pos -= 4;
>         else if ( name->indexOf(".bz", -3) != -1 )
>               pos -= 3;
> +      else if ( name->indexOf(".lzma", -5) != -1 )
> +            pos -= 5;
> +      else if ( name->indexOf(".xz", -3) != -1 )
> +            pos -= 3;
>   
>         if ( pos > 0 )
>               pos = name->lastIndexOf('.', pos-1);
> @@ -1317,6 +1321,10 @@
>                       end -= 2;
>                 else if ( len >= 4 && strcmp( end-3, ".bz2" ) == 0 )
>                       end -= 4;
> +      else if ( len >= 4 && strcmp( end-4, ".lzma" ) == 0 )

You meant len >=5

> +            end -= 5;
> +      else if ( len >= 3 && strcmp( end-2, ".xz" ) == 0 )
> +            end -= 3;
>   
>                 while ( end >= begin && *end != '.' )
>                       end--;



And check for identation problems.


["signature.asc" (application/pgp-signature)]

_______________________________________________
release-team mailing list
release-team@kde.org
https://mail.kde.org/mailman/listinfo/release-team


[prev in list] [next in list] [prev in thread] [next in thread]