From kde-print-devel Tue Sep 04 21:39:04 2007 From: Alex Merry Date: Tue, 04 Sep 2007 21:39:04 +0000 To: kde-print-devel Subject: [Kde-print-devel] Suggested KDEPrintInternal namespace Message-Id: <200709042239.09417.huntedhacker () tiscali ! co ! uk> X-MARC-Message: https://marc.info/?l=kde-print-devel&m=118894184503840 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0438262080==" --===============0438262080== Content-Type: multipart/signed; boundary="nextPart1444919.7uhPezaCNs"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart1444919.7uhPezaCNs Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline It has been mentioned before that KDEPrint pollutes the global namespace=20 extensively with many classes that do not begin with K. What's more,=20 these are almost all internal to KDEPrint, have no binary compatibility=20 guarantee and are used only by the KDEPrint management module in=20 kdebase (which is why there are exported). It would be good to put all the internal stuff in its own namespace. =20 The two obvious paths to take are: 1. Create a KDEPrint namespace with everything in, and put the internal=20 things in KDEPrint::internal 2. Leave the public classes alone, and put the internal things in a=20 KDEPrintInternal namespace (or KPrintInternal...) I think that at this stage, option 2 is better as less disruptive. =20 Also, the public classes generally seem to be named things like=20 KPrinter, KPrintDialogPage etc. =46eel free to shout this down as too intrusive, given that we're at Beta=20 stage, but if we're about to embark on an overhaul of KDEPrint then=20 this seems an obvious time to do it. Also, I'm only suggesting tidying=20 up the non-public classes into their own namespace. Does this seem like a good idea? Alex =2D-=20 KDE: http://www.kde.org Ubuntu/Kubuntu: http://www.ubuntu.org http://www.kubuntu.org --nextPart1444919.7uhPezaCNs Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQBG3dB4BRauKLutZ9ARAg89AJ9+2WR0/6TdrNkHssKiOrUF4c6ZhwCglxT0 gnt/iT1EMLFE6LlafFazmAU= =hn8Q -----END PGP SIGNATURE----- --nextPart1444919.7uhPezaCNs-- --===============0438262080== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-print-devel mailing list Kde-print-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-print-devel --===============0438262080==--