[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    D14585: avoid crash in MonitorPrivate::emitItemsNotification accessing empty list
From:       Daniel_Vrátil <noreply () phabricator ! kde ! org>
Date:       2018-08-04 10:33:44
Message-ID: 60947de15f28e08a7d94f1f6030e657d () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

dvratil requested changes to this revision.
dvratil added a comment.
This revision now requires changes to proceed.


  This is not the right place for the fix. The problem is either in the Monitor \
(somewhere between the point where notification enters the system and where it \
crashes Monitor somehow loses Items from the notification) or in the Akonadi Server \
(which emits notifications without Items which is wrong because such notification \
makes no sense and should not have happened in the first place).  
  According to the backtrace in the bug, the offending notification was an ItemAdded \
notification, so let's see if we can find where that came from.

REPOSITORY
  R165 Akonadi

REVISION DETAIL
  https://phabricator.kde.org/D14585

To: mkoller, dvratil
Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil


[Attachment #3 (text/html)]

<table><tr><td style="">dvratil requested changes to this revision.<br />dvratil \
added a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D14585">View \
Revision</a></tr></table><br /><div><div><p>This is not the right place for the fix. \
The problem is either in the Monitor (somewhere between the point where notification \
enters the system and where it crashes Monitor somehow loses Items from the \
notification) or in the Akonadi Server (which emits notifications without Items which \
is wrong because such notification makes no sense and should not have happened in the \
first place).</p>

<p>According to the backtrace in the bug, the offending notification was an ItemAdded \
notification, so let&#039;s see if we can find where that came \
from.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R165 Akonadi \
</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D14585">https://phabricator.kde.org/D14585</a></div></div><br \
/><div><strong>To: </strong>mkoller, dvratil<br /><strong>Cc: </strong>kde-pim, \
dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]