[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    D13816: Make KItinerary work as a static library
From:       Emmanuel Lepage Vallee <noreply () phabricator ! kde ! org>
Date:       2018-07-10 17:39:06
Message-ID: 0f404d241819c69e8ed8d594bf27605a () localhost ! localdomain
[Download RAW message or body]

[Attachment #2 (text/plain)]

lepagevalleeemmanuel added inline comments.

INLINE COMMENTS

> CMakeLists.txt:50
> 
> -add_library(KPimItinerary SHARED ${kitinerary_lib_srcs})
> +add_library(KPimItinerary ${kitinerary_lib_srcs})
> add_library(KPim::Itinerary ALIAS KPimItinerary)

Ok, thanks. So it's a "Ship it!" for my point of view (if it matter at all)

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

REVISION DETAIL
  https://phabricator.kde.org/D13816

To: vkrause, #frameworks
Cc: cgiboudeaux, arojas, mart, lepagevalleeemmanuel, apol, kde-pim, dvasin, \
rodsevich, winterz, vkrause, mlaurent, knauss, dvratil


[Attachment #3 (text/html)]

<table><tr><td style="">lepagevalleeemmanuel added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D13816">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D13816#inline-73747">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">CMakeLists.txt:50</span></div> <div \
style="font: 11px/15px &quot;Menlo&quot;, &quot;Consolas&quot;, &quot;Monaco&quot;, \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">add_library(KPimItinerary <span class="bright">SHARED \
</span>${kitinerary_lib_srcs}) </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">add_library(KPimItinerary \
${kitinerary_lib_srcs}) </div><div style="padding: 0 8px; margin: 0 4px; \
">add_library(KPim::Itinerary ALIAS KPimItinerary) </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Ok, \
thanks. So it&#039;s a &quot;Ship it!&quot; for my point of view (if it matter at \
all)</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R1003 KItinerary: Travel Reservation \
handling library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D13816">https://phabricator.kde.org/D13816</a></div></div><br \
/><div><strong>To: </strong>vkrause, Frameworks<br /><strong>Cc: \
</strong>cgiboudeaux, arojas, mart, lepagevalleeemmanuel, apol, kde-pim, dvasin, \
rodsevich, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]