[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    D12019: make sure to create unique filename in maildir resource
From:       Martin Koller <noreply () phabricator ! kde ! org>
Date:       2018-04-09 17:18:51
Message-ID: 20180409171851.1.062B404279E00C4E () phabricator ! kde ! org
[Download RAW message or body]

mkoller updated this revision to Diff 31754.
mkoller added a comment.


  changed to milliSeconds.
  Altough I'm not really sure if this is a good solution, since how can we know how \
fast computers will be in some years ?  And QUuid is there for exactly this reason - \
to generate a unique name.  Yes, the filenames are twice as long - altough: who cares \
? Do you think it hurts somewhere ?  
  I assume the rand seed init is not needed, since it does not matter what random \
numbers we get, and the comment  suggest that it was only there for QUuid (which was \
not used anyways...)

REPOSITORY
  R44 KDE PIM Runtime

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12019?vs=31584&id=31754

REVISION DETAIL
  https://phabricator.kde.org/D12019

AFFECTED FILES
  maildir/libmaildir/maildir.cpp

To: mkoller, mlaurent
Cc: dvratil, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss


[Attachment #3 (unknown)]

<table><tr><td style="">mkoller updated this revision to Diff 31754.<br />mkoller \
added a comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 \
8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D12019">View Revision</a></tr></table><br \
/><div><div><p>changed to milliSeconds.<br /> Altough I&#039;m not really sure if \
this is a good solution, since how can we know how fast computers will be in some \
years ?<br /> And QUuid is there for exactly this reason - to generate a unique \
name.<br /> Yes, the filenames are twice as long - altough: who cares ? Do you think \
it hurts somewhere ?</p>

<p>I assume the rand seed init is not needed, since it does not matter what random \
numbers we get, and the comment<br /> suggest that it was only there for QUuid (which \
was not used anyways...)</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R44 KDE PIM Runtime</div></div></div><br \
/><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a \
href="https://phabricator.kde.org/D12019?vs=31584&amp;id=31754">https://phabricator.kde.org/D12019?vs=31584&amp;id=31754</a></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D12019">https://phabricator.kde.org/D12019</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>maildir/libmaildir/maildir.cpp</div></div></div><br \
/><div><strong>To: </strong>mkoller, mlaurent<br /><strong>Cc: </strong>dvratil, KDE \
PIM, dvasin, winterz, vkrause, mlaurent, knauss<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]