[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: KHolidays as Framework (redux)
From: Dominik Haumann <dhaumann () kde ! org>
Date: 2018-01-20 16:37:02
Message-ID: CALi_srCPsGq03pm1-ESLkQ0EPeQ9HQ-yEDbO8ne-9GHooTCL_A () mail ! gmail ! com
[Download RAW message or body]
Am 20.01.2018 17:22 schrieb "Volker Krause" <vkrause@kde.org>:
Thanks, should be fixed now.
Certainly better, although code examples and the like still would make a
significant difference ;)
Cheers
Dominik
On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann wrote:
> Hi,
>
> CC: only kdepim, kde-frameworks-devel
>
> I have some general comments about the API documentation. Looking at
> https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html
> the list mostly (only?) contains classes that are internal. Looking at
> https://github.com/KDE/kholidays/blob/master/src/holiday.h
> we can see documentation exists also for important classes, but the docs
> are not listed because the class documentation is missing.
>
> This is not a showstopper, but without accessible API, the visibility of
> this framework is much reduced. It would be nice, if the API documentation
> is complete, so here is still some room for improvement ;)
>
> Best regards
> Dominik
>
>
>
> Am 20.01.2018 11:39 schrieb "Volker Krause" <vkrause@kde.org>:
>
> On Sunday, 14 January 2018 12:55:30 CET David Faure wrote:
> > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote:
> > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:
> > > > On Friday 01 January 2016 18:24:17 David Faure wrote:
> > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:
> > > > > > Hi,
> > > > > >
> > > > > > It's xmas holidays, so it must be time to poke a stick at
>
> KHolidays
>
> > > > > > again
> > > > > > for inclusion as a Framework. As far as I am aware there are no
> > > > > > outstanding
> > > > > > porting issues with KHolidays and it is ready for review to be
> > > > > > included
> > > > > > as
> > > > > > a Tier 1 Framework in the next possible release. What's the next
> > > > > > step?
> > > > >
> > > > > Please make sure it passes all of the items in this checklist
> > > > > https://community.kde.org/Frameworks/CreationGuidelines
> > > >
> > > > AFAICS this is followed, apart from using the KF5 version number and
> > > > actually being marked as a framework, which I guess is pending
>
> framework
>
> > > > approval.
> > >
> > > This got lost somehow, any objection to executing the move to
frameworks
> > > for 5.43, say end of this week?
> >
> > Go ahead.
>
> The necessary metainfo and CMake changes are pushed, the sysadmin ticket
for
> the repo metadata change is T7791.
>
> Summary: KHolidays will not be part of the 18.x KDE Application releases
> anymore, but instead become part of the KDE Frameworks releases with
version
> 5.43. There are no ABI or name changes, just the .so version increases
from
> 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully
be
> hardly noticeable.
> Side benefit: plasma-workspace no longer depends on a library from KDE
> Application releases.
>
> Regards,
> Volker
[Attachment #3 (text/html)]
<div dir="auto"><div><div class="gmail_extra"><div class="gmail_quote">Am 20.01.2018 \
17:22 schrieb "Volker Krause" <<a \
href="mailto:vkrause@kde.org">vkrause@kde.org</a>>:<br \
type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">Thanks, should be fixed \
now.<br></blockquote></div></div></div><div dir="auto"><br></div><div \
dir="auto">Certainly better, although code examples and the like still would make a \
significant difference ;)</div><div dir="auto"><br></div><div \
dir="auto">Cheers</div><div dir="auto">Dominik</div><div dir="auto"><br></div><div \
dir="auto"><br></div><div dir="auto"><br></div><div dir="auto"><div \
class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div \
class="elided-text"><br> On Saturday, 20 January 2018 15:17:53 CET Dominik Haumann \
wrote:<br> > Hi,<br>
><br>
> CC: only kdepim, kde-frameworks-devel<br>
><br>
> I have some general comments about the API documentation. Looking at<br>
> <a href="https://api.kde.org/stable/kdepimlibs-apidocs/kholidays/html/classes.html" \
rel="noreferrer" target="_blank">https://api.kde.org/stable/<wbr>kdepimlibs-apidocs/kholidays/<wbr>html/classes.html</a><br>
> the list mostly (only?) contains classes that are internal. Looking at<br>
> <a href="https://github.com/KDE/kholidays/blob/master/src/holiday.h" \
rel="noreferrer" target="_blank">https://github.com/KDE/<wbr>kholidays/blob/master/src/<wbr>holiday.h</a><br>
> we can see documentation exists also for important classes, but the docs<br>
> are not listed because the class documentation is missing.<br>
><br>
> This is not a showstopper, but without accessible API, the visibility of<br>
> this framework is much reduced. It would be nice, if the API documentation<br>
> is complete, so here is still some room for improvement ;)<br>
><br>
> Best regards<br>
> Dominik<br>
><br>
><br>
><br>
> Am 20.01.2018 11:39 schrieb "Volker Krause" <<a \
href="mailto:vkrause@kde.org">vkrause@kde.org</a>>:<br> ><br>
> On Sunday, 14 January 2018 12:55:30 CET David Faure wrote:<br>
> > On dimanche 14 janvier 2018 10:20:38 CET Volker Krause wrote:<br>
> > > On Tuesday, 6 September 2016 12:03:15 CET Volker Krause wrote:<br>
> > > > On Friday 01 January 2016 18:24:17 David Faure wrote:<br>
> > > > > On Thursday 24 December 2015 12:28:13 John Layt wrote:<br>
> > > > > > Hi,<br>
> > > > > ><br>
> > > > > > It's xmas holidays, so it must be time to poke a \
stick at<br> ><br>
> KHolidays<br>
><br>
> > > > > > again<br>
> > > > > > for inclusion as a Framework. As far as I am aware \
there are no<br> > > > > > > outstanding<br>
> > > > > > porting issues with KHolidays and it is ready for \
review to be<br> > > > > > > included<br>
> > > > > > as<br>
> > > > > > a Tier 1 Framework in the next possible release. \
What's the next<br> > > > > > > step?<br>
> > > > ><br>
> > > > > Please make sure it passes all of the items in this \
checklist<br> > > > > > <a \
href="https://community.kde.org/Frameworks/CreationGuidelines" rel="noreferrer" \
target="_blank">https://community.kde.org/<wbr>Frameworks/CreationGuidelines</a><br> \
> > > ><br> > > > > AFAICS this is followed, apart from using \
the KF5 version number and<br> > > > > actually being marked as a \
framework, which I guess is pending<br> ><br>
> framework<br>
><br>
> > > > approval.<br>
> > ><br>
> > > This got lost somehow, any objection to executing the move to \
frameworks<br> > > > for 5.43, say end of this week?<br>
> ><br>
> > Go ahead.<br>
><br>
> The necessary metainfo and CMake changes are pushed, the sysadmin ticket for<br>
> the repo metadata change is T7791.<br>
><br>
> Summary: KHolidays will not be part of the 18.x KDE Application releases<br>
> anymore, but instead become part of the KDE Frameworks releases with version<br>
> 5.43. There are no ABI or name changes, just the .so version increases from<br>
> 5.7 to 5.43 to match the rest of KF5, so the transition should hopefully be<br>
> hardly noticeable.<br>
> Side benefit: plasma-workspace no longer depends on a library from KDE<br>
> Application releases.<br>
><br>
> Regards,<br>
> Volker<br>
<br>
</div></blockquote></div><br></div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic