[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: D7291: pimcommon: autocorrectionwidget - QPointer guard dialogs
From:       Martin Koller <kollix () aon ! at>
Date:       2017-08-20 17:05:53
Message-ID: 1876162.Al89lzfUcr () lapi ! koller
[Download RAW message or body]

On Mittwoch, 16. August 2017 22:47:00 CEST Allen Winter wrote:
> This revision was automatically updated to reflect the committed changes.
> Closed by commit R95:31d081255687: \
> pimcommon/autocorrection/autocorrectionwidget.cpp - QPionter dialog guards \
> (authored by winterz). 
> REPOSITORY
> R95 PIM: Common Support
> 
> CHANGES SINCE LAST UPDATE
> https://phabricator.kde.org/D7291?vs=18091&id=18256
> 
> REVISION DETAIL
> https://phabricator.kde.org/D7291
> 
> AFFECTED FILES
> src/pimcommon/autocorrection/autocorrectionwidget.cpp
> 
> To: winterz, #kde_pim, dvratil
> Cc: dkurz, anthonyfieroni, #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, \
> dvratil 

This seems to be the reason that I can no longer build kmail on my openSuse 42.2 (gcc \
4.8.5) Had to make the attached changes.
Can you clarify, please ?

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\                        - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at


["diff" (diff)]

diff --git a/ktnef/src/ktnefmain.cpp b/ktnef/src/ktnefmain.cpp
index 2d523219c..729ee8430 100644
--- a/ktnef/src/ktnefmain.cpp
+++ b/ktnef/src/ktnefmain.cpp
@@ -479,7 +479,7 @@ void KTNEFMain::slotEditToolbars()
     saveMainWindowSettings(grp);
 
     QPointer<KEditToolBar> dlg = new KEditToolBar(factory());
-    connect(dlg, &KEditToolBar::newToolBarConfig, this, \
&KTNEFMain::slotNewToolbarConfig); +    connect(dlg.data(), \
&KEditToolBar::newToolBarConfig, this, &KTNEFMain::slotNewToolbarConfig);  \
dlg->exec();  delete dlg;
 }
diff --git a/src/editor/kmcomposerwin.cpp b/src/editor/kmcomposerwin.cpp
index c6c0d3ef1..f059346b5 100644
--- a/src/editor/kmcomposerwin.cpp
+++ b/src/editor/kmcomposerwin.cpp
@@ -3020,7 +3020,7 @@ void KMComposerWin::slotEditToolbars()
     saveMainWindowSettings(grp);
     QPointer<KEditToolBar> dlg = new KEditToolBar(guiFactory(), this);
 
-    connect(dlg, &KEditToolBar::newToolBarConfig, this, \
&KMComposerWin::slotUpdateToolbars); +    connect(dlg.data(), \
&KEditToolBar::newToolBarConfig, this, &KMComposerWin::slotUpdateToolbars);  
     dlg->exec();
     delete dlg;
diff --git a/src/job/createnewcontactjob.cpp b/src/job/createnewcontactjob.cpp
index 2caf64965..a9ddc617c 100644
--- a/src/job/createnewcontactjob.cpp
+++ b/src/job/createnewcontactjob.cpp
@@ -123,8 +123,8 @@ void CreateNewContactJob::slotResourceCreationDone(KJob *job)
 void CreateNewContactJob::createContact()
 {
     QPointer<Akonadi::ContactEditorDialog> dlg = new \
Akonadi::ContactEditorDialog(Akonadi::ContactEditorDialog::CreateMode, \
                mParentWidget);
-    connect(dlg, &Akonadi::ContactEditorDialog::contactStored, this, \
                &CreateNewContactJob::contactStored);
-    connect(dlg, &Akonadi::ContactEditorDialog::error, this, \
&CreateNewContactJob::slotContactEditorError); +    connect(dlg.data(), \
&Akonadi::ContactEditorDialog::contactStored, this, \
&CreateNewContactJob::contactStored); +    connect(dlg.data(), \
&Akonadi::ContactEditorDialog::error, this, \
&CreateNewContactJob::slotContactEditorError);  dlg->exec();
     delete dlg;
 }
diff --git a/src/kmmainwin.cpp b/src/kmmainwin.cpp
index df126281b..dd3d64b38 100644
--- a/src/kmmainwin.cpp
+++ b/src/kmmainwin.cpp
@@ -149,7 +149,7 @@ void KMMainWin::slotEditToolbars()
     KConfigGroup grp = KMKernel::self()->config()->group("Main Window");
     saveMainWindowSettings(grp);
     QPointer<KEditToolBar> dlg = new KEditToolBar(guiFactory(), this);
-    connect(dlg, &KEditToolBar::newToolBarConfig, this, &KMMainWin::slotUpdateGui);
+    connect(dlg.data(), &KEditToolBar::newToolBarConfig, this, \
&KMMainWin::slotUpdateGui);  
     dlg->exec();
     delete dlg;
diff --git a/src/kmreadermainwin.cpp b/src/kmreadermainwin.cpp
index 263a14bf3..7056cb419 100644
--- a/src/kmreadermainwin.cpp
+++ b/src/kmreadermainwin.cpp
@@ -659,7 +659,7 @@ void KMReaderMainWin::slotEditToolbars()
     KConfigGroup grp(KMKernel::self()->config(), "ReaderWindow");
     saveMainWindowSettings(grp);
     QPointer<KEditToolBar> dlg = new KEditToolBar(guiFactory(), this);
-    connect(dlg, &KEditToolBar::newToolBarConfig, this, \
&KMReaderMainWin::slotUpdateToolbars); +    connect(dlg.data(), \
&KEditToolBar::newToolBarConfig, this, &KMReaderMainWin::slotUpdateToolbars);  \
dlg->exec();  delete dlg;
 }



[prev in list] [next in list] [prev in thread] [next in thread]