[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    D6980: Create ~/.local/share/adblock/ if it doesn't exist
From:       Wolfgang Bauer <noreply () phabricator ! kde ! org>
Date:       2017-07-29 22:10:12
Message-ID: differential-rev-PHID-DREV-lmznfar6wowsae6jhlyu-req () phabricator ! kde ! org
[Download RAW message or body]

wbauer created this revision.
wbauer added a project: KDE PIM.

REVISION SUMMARY
  Otherwise saving manual filters will fail, which will also result in the general \
settings (Enable Ad Block, Hide filtered elements, Update interval) not getting \
written at all.

TEST PLAN
  Run Akregator or KMail on a fresh user account or delete ~/.local/share/adblock/ \
before you run it.  Enable the options "Enable Ad Block" and/or "Hide filtered \
elements" in the Adblock plugin settings (or disable them if they are already on) and \
click OK.  Quit and restart Akregator/KMail.
  
  The settings are remembered now, before they were reverted again.
  
  Also, adding custom manual filter rules works now and they are remembered.
  
  Debug message "Unable to open rule file \
/home/xxx/.local/share/adblock/adblockrules_local" disappears too with the patch.

REPOSITORY
  R81 KDE PIM Addons

REVISION DETAIL
  https://phabricator.kde.org/D6980

AFFECTED FILES
  plugins/webengineurlinterceptor/adblock/lib/widgets/adblocksettingwidget.cpp

To: wbauer, mlaurent
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil


[Attachment #3 (unknown)]

<table><tr><td style="">wbauer created this revision.<br />wbauer added a project: \
KDE PIM. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6980" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>Otherwise saving manual filters will fail, which will also \
result in the general settings (Enable Ad Block, Hide filtered elements, Update \
interval) not getting written at all.</p></div></div><br /><div><strong>TEST \
PLAN</strong><div><p>Run Akregator or KMail on a fresh user account or delete \
~/.local/share/adblock/ before you run it.<br /> Enable the options &quot;Enable Ad \
Block&quot; and/or &quot;Hide filtered elements&quot; in the Adblock plugin settings \
(or disable them if they are already on) and click OK.<br /> Quit and restart \
Akregator/KMail.</p>

<p>The settings are remembered now, before they were reverted again.</p>

<p>Also, adding custom manual filter rules works now and they are remembered.</p>

<p>Debug message &quot;Unable to open rule file \
/home/xxx/.local/share/adblock/adblockrules_local&quot; disappears too with the \
patch.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R81 KDE PIM \
Addons</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6980" \
rel="noreferrer">https://phabricator.kde.org/D6980</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>plugins/webengineurlinterceptor/adblock/lib/widgets/adblocksettingwidget.cpp</div></div></div><br \
/><div><strong>To: </strong>wbauer, mlaurent<br /><strong>Cc: </strong>KDE PIM, \
dvasin, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]