[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    D6516: Fix selecting the color from a set of filters
From:       Justus Winter <noreply () phabricator ! kde ! org>
Date:       2017-07-06 13:59:26
Message-ID: 20170706135924.8141.7451D772A3B5F0A0 () phabricator ! kde ! org
[Download RAW message or body]

justusw marked 3 inline comments as done.
justusw added a comment.


  In https://phabricator.kde.org/D6516#122148, @aheinecke wrote:
  
  > Looks good in general to me apart from my inline comments. The filter stuff I \
will test now because I can't see from the code if it works as intended.  
  
  Cool.
  
  > Regarding style: Please replace all tabs with 4 spaces. And we don't have a space \
between "!" and the statement.  
  Right.
  
  > The Style is documented under:
  >  https://techbase.kde.org/Policies/Kdelibs_Coding_Style
  > 
  > It even has an Emacs Mode for KDE ;-P
  
  The kde-emacs stuff doesn't work for me, also, it changes the indentation mode \
unconditionally, which I despise for obvious reasons.  Usually, I have a \
'do-the-right-thing' mode, I'm not sure why it failed for the formatting.cpp, maybe \
because of the local variables, which I took the liberty to update now.

REPOSITORY
  R90 PIM: Kleo Library

REVISION DETAIL
  https://phabricator.kde.org/D6516

To: justusw, aheinecke
Cc: #kde_pim, dvasin, winterz, vkrause, mlaurent, knauss, dvratil


[Attachment #3 (unknown)]

<table><tr><td style="">justusw marked 3 inline comments as done.<br />justusw added \
a comment. </td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; \
float: right; color: #464C5C; font-weight: bold; border-radius: 3px; \
background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); \
display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D6516" rel="noreferrer">View \
Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid \
#8C98B8;  color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6516#122148" \
style="background-color: #e7e7e7;  border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;" rel="noreferrer">D6516#122148</a>, <a \
href="https://phabricator.kde.org/p/aheinecke/" style="  border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;" rel="noreferrer">@aheinecke</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Looks good in general to me apart from my \
inline comments. The filter stuff I will test now because I can&#039;t see from the \
code if it works as intended.</p></div> </blockquote>

<p>Cool.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: \
#f8f9fc;"><p>Regarding style: Please replace all tabs with 4 spaces. And we \
don&#039;t have a space between &quot;!&quot; and the statement.</p></blockquote>

<p>Right.</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: \
italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>The \
Style is documented under:<br />  <a \
href="https://techbase.kde.org/Policies/Kdelibs_Coding_Style" class="remarkup-link" \
target="_blank" rel="noreferrer">https://techbase.kde.org/Policies/Kdelibs_Coding_Style</a></p>


<p>It even has an Emacs Mode for KDE ;-P</p></blockquote>

<p>The kde-emacs stuff doesn&#039;t work for me, also, it changes the indentation \
mode unconditionally, which I despise for obvious reasons.  Usually, I have a \
&#039;do-the-right-thing&#039; mode, I&#039;m not sure why it failed for the \
formatting.cpp, maybe because of the local variables, which I took the liberty to \
update now.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R90 PIM: \
Kleo Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D6516" \
rel="noreferrer">https://phabricator.kde.org/D6516</a></div></div><br \
/><div><strong>To: </strong>justusw, aheinecke<br /><strong>Cc: </strong>KDE PIM, \
dvasin, winterz, vkrause, mlaurent, knauss, dvratil<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]