[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: Review Request 128076: Remove duplicate setting of QT_DISABLE_DEPRECATED_BEFORE.
From: Milian Wolff <mail () milianw ! de>
Date: 2017-02-12 12:18:25
Message-ID: 20170212121825.10218.10957 () mimi ! kde ! org
[Download RAW message or body]
--===============3734033193517224668==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128076/
-----------------------------------------------------------
(Updated Feb. 12, 2017, 12:18 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDEPIM.
Repository: libkgapi
Description
-------
ECM does this for us, but it sets it to =0. Still, I can
compile it without this line and without the tons of
compiler warnings... So was this really needed?
Diffs
-----
CMakeLists.txt eac143e8ebe118c91f3635216671a147438d2eaf
Diff: https://git.reviewboard.kde.org/r/128076/diff/
Testing
-------
Thanks,
Milian Wolff
--===============3734033193517224668==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128076/">https://git.reviewboard.kde.org/r/128076/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDEPIM.</div>
<div>By Milian Wolff.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2017, 12:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkgapi
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ECM does this for us, but it sets it to =0. Still, I can compile it \
without this line and without the tons of compiler warnings... So was this really \
needed?</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(eac143e8ebe118c91f3635216671a147438d2eaf)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128076/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3734033193517224668==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic