[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: Review Request 127023: [KFileMetadata] Support Origin Email subject/sender/id
From: Kai Uwe Broulik <kde () privat ! broulik ! de>
Date: 2016-08-10 17:19:38
Message-ID: 20160810171938.9365.10772 () mimi ! kde ! org
[Download RAW message or body]
--===============5444979026961403488==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Aug. 10, 2016, 4:52 nachm., Kevin Funk wrote:
> > I'm late to the party, but ...: This won't fly on Windows (at least under MSVC). \
> > I'm not usually compiling kfilemetadata.git on Windows, so I wasn't affected by \
> > this change thus didn't notice.
> > Can we make the dependency on xattr optional so we can restore the build with \
> > MSVC?
Sure but I'm not very knowledgeable in CMake and don't have a Windows machine, so \
don't expect me to do it :)
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127023/#review98302
-----------------------------------------------------------
On Feb. 26, 2016, 7:56 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127023/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2016, 7:56 nachm.)
>
>
> Review request for KDE Frameworks, KDEPIM, Daniel Vrátil, Sebastian Kügler, and \
> Vishesh Handa.
>
> Repository: kfilemetadata
>
>
> Description
> -------
>
> This adds support for the user.xdg.origin.email.subject, \
> user.xdg.origin.email.sender, user.xdg.origin.email.message-id xattrs [1] to \
> KFileMetadata.
> This can (should :P) be populated by KMail when you save an attachment.
>
> Not too happy about the "displayName" I chose. Also we'll need to figure out what \
> to index and how we can relate this information and present it to the user in a \
> meaningful way. But at least let's collect the information first and then we can \
> think about ways to handle this.
> [1] https://wiki.freedesktop.org/www/CommonExtendedAttributes/
>
>
> Diffs
> -----
>
> src/properties.h 6ceaca5
> src/propertyinfo.cpp 4d1fac4
> src/usermetadata.h 9e10d2a
> src/usermetadata.cpp 5485d0e
>
> Diff: https://git.reviewboard.kde.org/r/127023/diff/
>
>
> Testing
> -------
>
> Not really. Tests pass, though.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============5444979026961403488==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127023/">https://git.reviewboard.kde.org/r/127023/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 10th, 2016, 4:52 nachm. UTC, <b>Kevin \
Funk</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm late to the party, but ...: This won't fly on \
Windows (at least under MSVC). I'm not usually compiling kfilemetadata.git on \
Windows, so I wasn't affected by this change thus didn't notice.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Can we make the dependency on xattr optional so we can restore the build \
with MSVC?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sure but I'm not \
very knowledgeable in CMake and don't have a Windows machine, so don't expect \
me to do it :)</pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On Februar 26th, 2016, 7:56 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, KDEPIM, Daniel Vrátil, Sebastian Kügler, \
and Vishesh Handa.</div> <div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 26, 2016, 7:56 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds support for the \
user.xdg.origin.email.subject, user.xdg.origin.email.sender, \
user.xdg.origin.email.message-id xattrs [1] to KFileMetadata.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
can (should :P) be populated by KMail when you save an attachment.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Not too happy about the "displayName" I chose. Also we'll need to figure \
out what to index and how we can relate this information and present it to the user \
in a meaningful way. But at least let's collect the information first and then we can \
think about ways to handle this.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">[1] \
https://wiki.freedesktop.org/www/CommonExtendedAttributes/</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Not really. Tests pass, though.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/properties.h <span style="color: grey">(6ceaca5)</span></li>
<li>src/propertyinfo.cpp <span style="color: grey">(4d1fac4)</span></li>
<li>src/usermetadata.h <span style="color: grey">(9e10d2a)</span></li>
<li>src/usermetadata.cpp <span style="color: grey">(5485d0e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127023/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5444979026961403488==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic