[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 126703: Use KSharedConfig::openConfig("kmail2rc") to try and optimize a
From: "Laurent Montel" <montel () kde ! org>
Date: 2016-01-10 14:10:01
Message-ID: 20160110141001.23702.15684 () mimi ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126703/#review90840
-----------------------------------------------------------
Ship it!
Ship it.
- Laurent Montel
On jan. 10, 2016, 1:22 après-midi, David Faure wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126703/
> -----------------------------------------------------------
>
> (Updated jan. 10, 2016, 1:22 après-midi)
>
>
> Review request for KDEPIM-Libraries and Laurent Montel.
>
>
> Repository: kidentitymanagement
>
>
> Description
> -------
>
> Of course it only helps if we're called by kmail or kontact, not that
> much in standalone korganizer.
>
> At least KIdentityManagement::thatIsMe has a cache, unlike the kde4 version
> of kcalutils/incidenceformatter.cpp's thatIsMe which created an IdentityManager
> instance every time (which made me look into this).
>
>
> Diffs
> -----
>
> src/identitymanager.cpp 8fa5beede24d948401193be0e450e06644e3fbe0
>
> Diff: https://git.reviewboard.kde.org/r/126703/diff/
>
>
> Testing
> -------
>
> Compiles, kpimidentity-identitytest passes.
>
>
> Thanks,
>
> David Faure
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic