[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 125726: Remove DataRetriever and Loader from Syndication
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2015-10-22 16:26:37
Message-ID: 20151022162637.14267.20780 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125726/#review87272
-----------------------------------------------------------


Looks good to me.

- Volker Krause


On Oct. 20, 2015, 2:56 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125726/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 2:56 p.m.)
> 
> 
> Review request for KDEPIM and Frank Osterfeld.
> 
> 
> Repository: syndication
> 
> 
> Description
> -------
> 
> Those were just convenience classes for retrieving the feeds via KIO. Removing them \
> allows us to drop the KIO dependency completely. 
> I only preserved discoverFeedURL(), which is non-trivial, the rest can be easily \
> handled by applications. 
> 
> Diffs
> -----
> 
> CMakeLists.txt e833c1b 
> src/syndication/CMakeLists.txt 74dd9b0 
> src/syndication/dataretriever.h 648c824 
> src/syndication/dataretriever.cpp da53496 
> src/syndication/global.h 78f8566 
> src/syndication/global.cpp 79aefad 
> src/syndication/loader.h ba70af0 
> src/syndication/loader.cpp c77bf5f 
> src/syndication/syndication.h d0e1094 
> tests/CMakeLists.txt 173b7fe 
> tests/testloader.h afaa6c1 
> tests/testloader.cpp 22ade3d 
> 
> Diff: https://git.reviewboard.kde.org/r/125726/diff/
> 
> 
> Testing
> -------
> 
> Adapted Akregator, everything seems to work.
> 
> 
> Thanks,
> 
> Daniel Vrátil
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]