[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 125747: Check calendar pointer before access it in writeFile() in kalar
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2015-10-22 16:15:02
Message-ID: 20151022161502.14267.27122 () mimi ! kde ! org
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125747/#review87268
-----------------------------------------------------------


Looks good to me.

- Volker Krause


On Oct. 21, 2015, 10:47 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125747/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 10:47 p.m.)
> 
> 
> Review request for KDEPIM, Laurent Montel and Sergio Martins.
> 
> 
> Repository: kdepim-runtime
> 
> 
> Description
> -------
> 
> As a side-effect caused by 1612e91eb5540fc25e4fa4a7bfe28d3512439318, now kalarm \
> resource would crash when stop or being created.  
> Not quite sure if this is the correct fix, but ICalResourceBase seems did a lot of \
> check on mCalendar, so I guess check calendar() in kalarma also makes sense? 
> 
> Diffs
> -----
> 
> resources/kalarm/kalarm/kalarmresource.cpp f0d9a27 
> 
> Diff: https://git.reviewboard.kde.org/r/125747/diff/
> 
> 
> Testing
> -------
> 
> No crash on kalarm resource in the same situation.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]