[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 125710: Deal with akregator part main widget being externally deleted.
From: "Allen Winter" <winter () kde ! org>
Date: 2015-10-19 21:54:19
Message-ID: 20151019215419.14267.31901 () mimi ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125710/#review87103
-----------------------------------------------------------
Ship it!
Ship It!
- Allen Winter
On Oct. 19, 2015, 7:07 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125710/
> -----------------------------------------------------------
>
> (Updated Oct. 19, 2015, 7:07 p.m.)
>
>
> Review request for KDEPIM and Laurent Montel.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> Running akregator under valgrind (to track down a different crash), I
> got that the main widget was deleted from the event loop (by
> qDeleteInEventHandler), which then triggered the deletion of the
> akregator part, which then tried to access the (now deleted) widget.
>
> This should prevent the code from crashing in this case.
>
>
> Diffs
> -----
>
> akregator/src/akregator_part.cpp 185899c1f9987c091d01f8c8c025c229c9455891
>
> Diff: https://git.reviewboard.kde.org/r/125710/diff/
>
>
> Testing
> -------
>
> Built, ran and quit akregator (both under valgrind and not).
>
>
> Thanks,
>
> Alex Merry
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic