'Re: [Kde-pim] Review Request 125577: Extend the purpose of GrantleeTheme library and refresh the KMa'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    Re: [Kde-pim] Review Request 125577: Extend the purpose of GrantleeTheme library and refresh the KMa
From:       "Volker Krause" <vkrause () kde ! org>
Date:       2015-10-10 10:00:46
Message-ID: 20151010100046.17685.75120 () mimi ! kde ! org
[Download RAW message or body]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125577/#review86614
-----------------------------------------------------------

Nice!

grantleetheme/src/grantleethememanager.cpp (line 321)
<https://git.reviewboard.kde.org/r/125577/#comment59621>

    value() already returns a default-constructed object if none is found, so the \
extra contains() condition here is not needed.

grantleetheme/src/plugin/pimgrantleeplugin.h (line 30)
<https://git.reviewboard.kde.org/r/125577/#comment59622>

    This doesn't match the class name? Also, this plugin seems to be for KIcon \
integration, not PIM related, so maybe name it accordingly? :)

- Volker Krause

On Oct. 9, 2015, 10:54 p.m., Daniel Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125577/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 10:54 p.m.)
> 
> 
> Review request for KDEPIM and Laurent Montel.
> 
> 
> Repository: kdepim
> 
> 
> Description
> -------
> 
> So, this tiny patch does two things (it can be split when committed, but for \
> discussion I think it's better to have it as one): 1) it repurposes GrantleeTheme \
> to be able to not just manage Grantlee theme packs, but also to render them. I \
> basically forked some of the logic from the Grantlee template management code I \
> wrote for KCalUtils (once GrantleeTheme is split out of kdepim, I'll make KCalUtils \
> use it). This is useful because the way we use Grantlee is very repetitive (Engine, \
> Loader -> load plugins -> render), so wrapping that into GrantleeTheme::Theme looks \
> like a good idea, it hides the ugliness of the theme/template path lookup. 
> 2) it creates new Grantlee templates for the "Introduction" pages for KMail and \
> Kontact (Help -> Introduction), as well as the "Retrieving folder contents ..." \
> page and similar info views shown in KMail. We do it using the extended \
> GrantleeTheme functionality. See the attached screenshots - if this ain't \
> superfancy, I don't know what is...:) 
> PS: Akregator has the same infopage too, but it's not using MessageViewer for \
> obvious reasons, so the way there would be to copy the create Akregator's own \
> Grantlee theme and make Akregator use GrantleeTheme as well. Let's do it once the \
> underlaying stuff is in. 
> 
> Diffs
> -----
> 
> grantleetheme/CMakeLists.txt 8e071a4 
> grantleetheme/src/CMakeLists.txt c936c84 
> grantleetheme/src/grantleeki18nlocalizer.cpp PRE-CREATION 
> grantleetheme/src/grantleeki18nlocalizer_p.h PRE-CREATION 
> grantleetheme/src/grantleetheme.h 995ee58 
> grantleetheme/src/grantleetheme.cpp ae0cafd 
> grantleetheme/src/grantleetheme_p.h PRE-CREATION 
> grantleetheme/src/grantleethememanager.h d08bcb7 
> grantleetheme/src/grantleethememanager.cpp 4e887a6 
> grantleetheme/src/plugin/CMakeLists.txt PRE-CREATION 
> grantleetheme/src/plugin/icon.h PRE-CREATION 
> grantleetheme/src/plugin/icon.cpp PRE-CREATION 
> grantleetheme/src/plugin/pimgrantleeplugin.h PRE-CREATION 
> grantleetheme/src/plugin/pimgrantleeplugin.cpp PRE-CREATION 
> kaddressbook/mainwidget.h 9c9946f 
> kaddressbook/mainwidget.cpp 734a3c3 
> kaddressbookgrantlee/src/widget/grantleecontactviewer.cpp 56c2a9f 
> kmail/about/CMakeLists.txt c10672a 
> kmail/about/introduction_kmail.html PRE-CREATION 
> kmail/about/kmail.css 4cddf98 
> kmail/about/main.html 6d86a45 
> kmail/about/top-left-kmail.png f705363 
> kmail/kmreaderwin.h f1e0f40 
> kmail/kmreaderwin.cpp b824140 
> kontact/src/CMakeLists.txt ca52422 
> kontact/src/about/CMakeLists.txt 123fb3c 
> kontact/src/about/introduction_kontact.html PRE-CREATION 
> kontact/src/about/kontact.css 59de61d 
> kontact/src/about/loading_kontact.html PRE-CREATION 
> kontact/src/about/main.html 60845da 
> kontact/src/about/top-left-kontact.png 94d7248 
> kontact/src/mainwindow.h 7387cbc 
> kontact/src/mainwindow.cpp 8725b5e 
> messageviewer/CMakeLists.txt 5d56eb8 
> messageviewer/src/CMakeLists.txt fd65489 
> messageviewer/src/about/CMakeLists.txt PRE-CREATION 
> messageviewer/src/about/default/CMakeLists.txt PRE-CREATION 
> messageviewer/src/about/default/background.png PRE-CREATION 
> messageviewer/src/about/default/main.css PRE-CREATION 
> messageviewer/src/about/default/main.html PRE-CREATION 
> messageviewer/src/about/default/splash.theme PRE-CREATION 
> messageviewer/src/about/default/status.html PRE-CREATION 
> messageviewer/src/header/grantleeheaderstyleplugin/grantleeheaderstyleinterface.h \
> 1fdf939  messageviewer/src/header/grantleeheaderstyleplugin/grantleeheaderstyleinterface.cpp \
> 50325c4  messageviewer/src/viewer/mailwebview_webkit.cpp c452660 
> messageviewer/src/viewer/viewer.h ef98fe9 
> messageviewer/src/viewer/viewer.cpp 1f1b12f 
> messageviewer/src/viewer/viewer_p.h 03e2b77 
> messageviewer/src/viewer/viewer_p.cpp 023ce11 
> 
> Diff: https://git.reviewboard.kde.org/r/125577/diff/
> 
> 
> Testing
> -------
> 
> Yes, works. The only problem seems to be that sometimes QtWebKit is ridiculously \
> slow rendering the background wallpaper, so you can see it slowly render, as if you \
> were downloading it via 56k modem - but I guess there's not much we can do about \
> it. 
> 
> File Attachments
> ----------------
> 
> KMail Introduction
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/09/6a6b83c8-aca5-4269-9e66-f79e1e1c10e7__kmail.png
>  KMail "busy" page
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/09/aef41331-c1a0-4778-b342-45f9e868d1bc__kmail3.png
>  Kontact Introduction
> https://git.reviewboard.kde.org/media/uploaded/files/2015/10/09/bb6c4cbb-97d3-42b1-b677-d2c8c10bd111__kontact.png
>  
> 
> Thanks,
> 
> Daniel Vrátil
> 
> 

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/

[prev in list] [next in list] [prev in thread] [next in thread] 