[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: [Kde-pim] Review Request 125331: Port part of KCalUtils::IncidenceFormatter to Grantlee template
From: Sandro_Knauß <sknauss () kde ! org>
Date: 2015-10-05 22:16:46
Message-ID: 20151005221646.17685.83425 () mimi ! kde ! org
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125331/#review86396
-----------------------------------------------------------
Ship it!
If the issues are solved, ship it.
templates/attendee_row.html (line 27)
<https://git.reviewboard.kde.org/r/125331/#comment59520>
are you sure you can add translations via _("...") in grantlee?
autotests/data/event-allday.ical (line 21)
<https://git.reviewboard.kde.org/r/125331/#comment59515>
newlines at the end
autotests/data/event-exception-single.ical (line 21)
<https://git.reviewboard.kde.org/r/125331/#comment59516>
newlines
autotests/data/event-exception-single.ical (line 21)
<https://git.reviewboard.kde.org/r/125331/#comment59517>
newlines
autotests/data/event-multiday.ical (line 22)
<https://git.reviewboard.kde.org/r/125331/#comment59518>
newlines
- Sandro Knauß
On Okt. 5, 2015, 6:52 nachm., Daniel Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125331/
> -----------------------------------------------------------
>
> (Updated Okt. 5, 2015, 6:52 nachm.)
>
>
> Review request for KDEPIM, Laurent Montel and Volker Krause.
>
>
> Repository: kcalutils
>
>
> Description
> -------
>
> I needed to extend the HTML generated for todos so that it includes some more \
> fields useful for the Phabricator resource. After digging around the code a bit a \
> decided to see if I can port it to Grantlee, which is way easier to maintain and \
> modify and also provides much cleaner separation between logic and representation \
> and this is the result of it :)
> This patch does not port the entire IndicendeFormatter to Grantlee, only events, \
> tasks, journals and free/busy, I haven't touched the ITIP formatter yet.
> The new code works just fine, but I consider it more of a proof-of-concept than a \
> ready-to-ship patch and I'd like to get your input regarding the use of Grantlee - \
> should we use a QObject wrapper for KCalCore::Incidence instead of QVariantHash, or \
> maybe use the Grantlee MetaType system directly for thinner-than-QObject wrappers, \
> should we use the custom Grantlee plugin, ...?
> Also please see the mail on kde-pim regarding where should we put the plugin :)
>
>
> Diffs
> -----
>
> CMakeLists.txt d145b6a
> Messages.sh PRE-CREATION
> autotests/CMakeLists.txt a7ce2f1
> autotests/data/broken-template.html PRE-CREATION
> autotests/data/event-1.html PRE-CREATION
> autotests/data/event-1.ical PRE-CREATION
> autotests/data/event-2.html PRE-CREATION
> autotests/data/event-2.ical PRE-CREATION
> autotests/data/event-allday-multiday.html PRE-CREATION
> autotests/data/event-allday-multiday.ical PRE-CREATION
> autotests/data/event-allday.html PRE-CREATION
> autotests/data/event-allday.ical PRE-CREATION
> autotests/data/event-exception-single.html PRE-CREATION
> autotests/data/event-exception-single.ical PRE-CREATION
> autotests/data/event-exception-thisandfuture.html PRE-CREATION
> autotests/data/event-exception-thisandfuture.ical PRE-CREATION
> autotests/data/event-multiday.html PRE-CREATION
> autotests/data/event-multiday.ical PRE-CREATION
> autotests/data/event-recurrence-single.out.html PRE-CREATION
> autotests/data/event-recurrence-thisandfuture.out.html PRE-CREATION
> autotests/data/freebusy-1.html PRE-CREATION
> autotests/data/freebusy-1.ical PRE-CREATION
> autotests/data/journal-1.html PRE-CREATION
> autotests/data/journal-1.ical PRE-CREATION
> autotests/data/todo-1.html PRE-CREATION
> autotests/data/todo-1.ical PRE-CREATION
> autotests/test_config.h.cmake PRE-CREATION
> autotests/testincidenceformatter.h 0065745
> autotests/testincidenceformatter.cpp 28dd952
> scripts/extract_strings_ki18n.py PRE-CREATION
> scripts/grantlee_strings_extractor.py PRE-CREATION
> src/CMakeLists.txt 0d7bdcc
> src/Messages.sh 5f5de62
> src/grantlee_plugin/CMakeLists.txt PRE-CREATION
> src/grantlee_plugin/datetimefilters.h PRE-CREATION
> src/grantlee_plugin/datetimefilters.cpp PRE-CREATION
> src/grantlee_plugin/icon.h PRE-CREATION
> src/grantlee_plugin/icon.cpp PRE-CREATION
> src/grantlee_plugin/kcalendargrantleeplugin.h PRE-CREATION
> src/grantlee_plugin/kcalendargrantleeplugin.cpp PRE-CREATION
> src/grantleeki18nlocalizer.cpp PRE-CREATION
> src/grantleeki18nlocalizer_p.h PRE-CREATION
> src/grantleetemplatemanager.cpp PRE-CREATION
> src/grantleetemplatemanager_p.h PRE-CREATION
> src/incidenceformatter.cpp c58e961
> templates/CMakeLists.txt PRE-CREATION
> templates/attendee_row.html PRE-CREATION
> templates/event.html PRE-CREATION
> templates/freebusy.html PRE-CREATION
> templates/incidence_header.html PRE-CREATION
> templates/journal.html PRE-CREATION
> templates/template_base.html PRE-CREATION
> templates/todo.html PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125331/diff/
>
>
> Testing
> -------
>
> I can see my events.
>
>
> Thanks,
>
> Daniel Vrátil
>
>
_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic